From 1b3b702a7ec04fecb81f2642ffdde0b13e38a921 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20Br=C3=A9ard?= Date: Thu, 15 Aug 2024 02:51:12 -0400 Subject: [PATCH] fix(create-vite): move ESLint "ignores" config to a separate object in React templates (#17885) --- .../template-react-ts/eslint.config.js | 40 ++++++++++--------- .../template-react/eslint.config.js | 2 +- 2 files changed, 22 insertions(+), 20 deletions(-) diff --git a/packages/create-vite/template-react-ts/eslint.config.js b/packages/create-vite/template-react-ts/eslint.config.js index c4bc8f33c0b03e..092408a9f09eae 100644 --- a/packages/create-vite/template-react-ts/eslint.config.js +++ b/packages/create-vite/template-react-ts/eslint.config.js @@ -4,23 +4,25 @@ import reactHooks from 'eslint-plugin-react-hooks' import reactRefresh from 'eslint-plugin-react-refresh' import tseslint from 'typescript-eslint' -export default tseslint.config({ - extends: [js.configs.recommended, ...tseslint.configs.recommended], - files: ['**/*.{ts,tsx}'], - ignores: ['dist'], - languageOptions: { - ecmaVersion: 2020, - globals: globals.browser, +export default tseslint.config( + { ignores: ['dist'] }, + { + extends: [js.configs.recommended, ...tseslint.configs.recommended], + files: ['**/*.{ts,tsx}'], + languageOptions: { + ecmaVersion: 2020, + globals: globals.browser, + }, + plugins: { + 'react-hooks': reactHooks, + 'react-refresh': reactRefresh, + }, + rules: { + ...reactHooks.configs.recommended.rules, + 'react-refresh/only-export-components': [ + 'warn', + { allowConstantExport: true }, + ], + }, }, - plugins: { - 'react-hooks': reactHooks, - 'react-refresh': reactRefresh, - }, - rules: { - ...reactHooks.configs.recommended.rules, - 'react-refresh/only-export-components': [ - 'warn', - { allowConstantExport: true }, - ], - }, -}) +) diff --git a/packages/create-vite/template-react/eslint.config.js b/packages/create-vite/template-react/eslint.config.js index 964a299ddfa52e..238d2e4e6436b3 100644 --- a/packages/create-vite/template-react/eslint.config.js +++ b/packages/create-vite/template-react/eslint.config.js @@ -5,9 +5,9 @@ import reactHooks from 'eslint-plugin-react-hooks' import reactRefresh from 'eslint-plugin-react-refresh' export default [ + { ignores: ['dist'] }, { files: ['**/*.{js,jsx}'], - ignores: ['dist'], languageOptions: { ecmaVersion: 2020, globals: globals.browser,