perf: replace endsWith with ===

Author: sun0day

packages/vite/src/node/optimizer/scan.ts

@@ -17,8 +17,12 @@ import {
   createDebugger,
   dataUrlRE,
   externalRE,
+  isAstroExt,
+  isHtmlExt,
   isObject,
   isOptimizable,
+  isSvelteExt,
+  isVueExt,
   moduleListContains,
   multilineCommentsRE,
   normalizePath,
@@ -366,7 +370,7 @@ function esbuildScanPlugin(
           let raw = fs.readFileSync(path, 'utf-8')
           // Avoid matching the content of the comment
           raw = raw.replace(commentRE, '<!---->')
-          const isHtml = path.endsWith('.html')
+          const isHtml = isHtmlExt(path)
           const regex = isHtml ? scriptModuleRE : scriptRE
           regex.lastIndex = 0
           let js = ''
@@ -394,7 +398,7 @@ function esbuildScanPlugin(
             let loader: Loader = 'js'
             if (lang === 'ts' || lang === 'tsx' || lang === 'jsx') {
               loader = lang
-            } else if (path.endsWith('.astro')) {
+            } else if (isAstroExt(path)) {
               loader = 'ts'
             }
             const srcMatch = openTag.match(srcRE)
@@ -445,7 +449,7 @@ function esbuildScanPlugin(
               // Especially for Svelte files, exports in <script context="module"> means module exports,
               // exports in <script> means component props. To avoid having two same export name from the
               // star exports, we need to ignore exports in <script>
-              if (path.endsWith('.svelte') && context !== 'module') {
+              if (isSvelteExt(path) && context !== 'module') {
                 js += `import ${virtualModulePath}\n`
               } else {
                 js += `export * from ${virtualModulePath}\n`
@@ -457,7 +461,7 @@ function esbuildScanPlugin(
           // anywhere in a string. Svelte and Astro files can't have
           // `export default` as code so we know if it's encountered it's a
           // false positive (e.g. contained in a string)
-          if (!path.endsWith('.vue') || !js.includes('export default')) {
+          if (!isVueExt(path) || !js.includes('export default')) {
             js += '\nexport default {}'
           }
 

packages/vite/src/node/packages.ts

@@ -1,7 +1,7 @@
 import fs from 'node:fs'
 import path from 'node:path'
 import { createRequire } from 'node:module'
-import { createFilter, safeRealpathSync } from './utils'
+import { createFilter, isJsonExt, safeRealpathSync } from './utils'
 import type { ResolvedConfig } from './config'
 import type { Plugin } from './plugin'
 
@@ -204,7 +204,7 @@ export function watchPackageDataPlugin(config: ResolvedConfig): Plugin {
   const { packageCache } = config
   const setPackageData = packageCache.set.bind(packageCache)
   packageCache.set = (id, pkg) => {
-    if (id.endsWith('.json')) {
+    if (isJsonExt(id)) {
       watchFile(id)
     }
     return setPackageData(id, pkg)

packages/vite/src/node/plugins/asset.ts

@@ -19,6 +19,8 @@ import type { ResolvedConfig } from '../config'
 import {
   cleanUrl,
   getHash,
+  isHtmlExt,
+  isSvgExt,
   joinUrlSegments,
   normalizePath,
   removeLeadingSlash,
@@ -333,8 +335,8 @@ async function fileToBuiltUrl(
   let url: string
   if (
     config.build.lib ||
-    (!file.endsWith('.svg') &&
-      !file.endsWith('.html') &&
+    (!isSvgExt(file) &&
+      !isHtmlExt(file) &&
       content.length < Number(config.build.assetsInlineLimit) &&
       !isGitLfsPlaceholder(content))
   ) {

packages/vite/src/node/plugins/esbuild.ts

@@ -18,6 +18,7 @@ import {
   createFilter,
   ensureWatchedFile,
   generateCodeFrame,
+  isJsonExt,
 } from '../utils'
 import type { ResolvedConfig, ViteDevServer } from '..'
 import type { Plugin } from '../plugin'
@@ -481,8 +482,7 @@ function reloadOnTsconfigChange(changedFile: string) {
   // any json file in the tsconfig cache could have been used to compile ts
   if (
     path.basename(changedFile) === 'tsconfig.json' ||
-    (changedFile.endsWith('.json') &&
-      tsconfckParseOptions?.cache?.has(changedFile))
+    (isJsonExt(changedFile) && tsconfckParseOptions?.cache?.has(changedFile))
   ) {
     server.config.logger.info(
       `changed tsconfig file detected: ${changedFile} - Clearing cache and forcing full-reload to ensure TypeScript is compiled with updated config values.`,

packages/vite/src/node/plugins/html.ts

@@ -18,6 +18,7 @@ import {
   getHash,
   isDataUrl,
   isExternalUrl,
+  isHtmlExt,
   isUrl,
   normalizePath,
   processSrcSet,
@@ -303,7 +304,7 @@ export function buildHtmlPlugin(config: ResolvedConfig): Plugin {
     name: 'vite:build-html',
 
     async transform(html, id) {
-      if (id.endsWith('.html')) {
+      if (isHtmlExt(id)) {
         const relativeUrlPath = path.posix.relative(
           config.root,
           normalizePath(id),

packages/vite/src/node/plugins/importAnalysis.ts

@@ -33,6 +33,10 @@ import {
   isDataUrl,
   isExternalUrl,
   isJSRequest,
+  isJsonExt,
+  isJsxExt,
+  isTsxExt,
+  isVueExt,
   joinUrlSegments,
   moduleListContains,
   normalizePath,
@@ -223,8 +227,8 @@ export function importAnalysisPlugin(config: ResolvedConfig): Plugin {
       try {
         ;[imports, exports] = parseImports(source)
       } catch (e: any) {
-        const isVue = importer.endsWith('.vue')
-        const isJsx = importer.endsWith('.jsx') || importer.endsWith('.tsx')
+        const isVue = isVueExt(importer)
+        const isJsx = isJsxExt(importer) || isTsxExt(importer)
         const maybeJSX = !isVue && isJSRequest(importer)
 
         const msg = isVue
@@ -498,7 +502,7 @@ export function importAnalysisPlugin(config: ResolvedConfig): Plugin {
           if (
             specifier[0] === '/' &&
             !config.assetsInclude(cleanUrl(specifier)) &&
-            !specifier.endsWith('.json') &&
+            !isJsonExt(specifier) &&
             checkPublicFile(specifier, config)
           ) {
             throw new Error(

packages/vite/src/node/plugins/importAnalysisBuild.ts

@@ -9,6 +9,7 @@ import {
   bareImportRE,
   cleanUrl,
   combineSourcemaps,
+  isCssExt,
   isDataUrl,
   isExternalUrl,
   moduleListContains,
@@ -527,7 +528,7 @@ export function buildImportAnalysisPlugin(config: ResolvedConfig): Plugin {
                     const cssDeps: string[] = []
                     const otherDeps: string[] = []
                     for (const dep of depsArray) {
-                      ;(dep.endsWith('.css') ? cssDeps : otherDeps).push(dep)
+                      ;(isCssExt(dep) ? cssDeps : otherDeps).push(dep)
                     }
                     resolvedDeps = [
                       ...resolveDependencies(normalizedFile, otherDeps, {

packages/vite/src/node/plugins/reporter.ts

@@ -4,7 +4,7 @@ import { promisify } from 'node:util'
 import colors from 'picocolors'
 import type { Plugin } from 'rollup'
 import type { ResolvedConfig } from '../config'
-import { isDefined, normalizePath } from '../utils'
+import { isCssExt, isDefined, isSourceMapExt, normalizePath } from '../utils'
 import { LogLevels } from '../logger'
 
 const groups = [
@@ -142,8 +142,8 @@ export function buildReporterPlugin(config: ResolvedConfig): Plugin {
                     mapSize: chunk.map ? chunk.map.toString().length : null,
                   }
                 } else {
-                  if (chunk.fileName.endsWith('.map')) return null
-                  const isCSS = chunk.fileName.endsWith('.css')
+                  if (isSourceMapExt(chunk.fileName)) return null
+                  const isCSS = isCssExt(chunk.fileName)
                   return {
                     name: chunk.fileName,
                     group: isCSS ? 'CSS' : 'Assets',

packages/vite/src/node/plugins/resolve.ts

@@ -27,6 +27,8 @@ import {
   isBuiltin,
   isDataUrl,
   isExternalUrl,
+  isHtmlExt,
+  isMjsExt,
   isNonDriveRelativeAbsolutePath,
   isObject,
   isOptimizable,
@@ -281,7 +283,7 @@ export function resolvePlugin(resolveOptions: InternalResolveOptions): Plugin {
       // relative
       if (
         id[0] === '.' ||
-        ((preferRelative || importer?.endsWith('.html')) &&
+        ((preferRelative || isHtmlExt(importer)) &&
           startsWithWordCharRE.test(id))
       ) {
         const basedir = importer ? path.dirname(importer) : process.cwd()
@@ -962,7 +964,7 @@ export function resolvePackageEntry(
     if (
       targetWeb &&
       options.browserField &&
-      (!entryPoint || entryPoint.endsWith('.mjs'))
+      (!entryPoint || isMjsExt(entryPoint))
     ) {
       // check browser field
       // https://github.com/defunctzombie/package-browser-field-spec
@@ -1006,7 +1008,7 @@ export function resolvePackageEntry(
 
     // fallback to mainFields if still not resolved
     // TODO: review if `.mjs` check is still needed
-    if (!resolvedFromExports && (!entryPoint || entryPoint.endsWith('.mjs'))) {
+    if (!resolvedFromExports && (!entryPoint || isMjsExt(entryPoint))) {
       for (const field of options.mainFields) {
         if (field === 'browser') continue // already checked above
         if (typeof data[field] === 'string') {

packages/vite/src/node/server/hmr.ts

@@ -5,7 +5,13 @@ import colors from 'picocolors'
 import type { Update } from 'types/hmrPayload'
 import type { RollupError } from 'rollup'
 import { CLIENT_DIR } from '../constants'
-import { createDebugger, normalizePath, unique, wrapId } from '../utils'
+import {
+  createDebugger,
+  isHtmlExt,
+  normalizePath,
+  unique,
+  wrapId,
+} from '../utils'
 import type { ViteDevServer } from '..'
 import { isCSSRequest } from '../plugins/css'
 import { getAffectedGlobModules } from '../plugins/importMetaGlob'
@@ -110,7 +116,7 @@ export async function handleHMRUpdate(
 
   if (!hmrContext.modules.length) {
     // html file cannot be hot updated
-    if (file.endsWith('.html')) {
+    if (isHtmlExt(file)) {
       config.logger.info(colors.green(`page reload `) + colors.dim(shortFile), {
         clear: true,
         timestamp: true,