-
-
Notifications
You must be signed in to change notification settings - Fork 178
feat(vue-jsx): allow esbuild to perform ts transformation #621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation looks good to me. Would you
- resolve the conflicts?
- fix the lint error?
By the way, do you have any performance numbers for each transform? I'm wondering if the plugin should use tsTransform: 'built-in'
in the future as that would align to how plugin-react works.
No problem - done.
Simple comparisons of For a "naive" approach in playground
For a real medium Nuxt project I have
For a real very large Nuxt project I have
|
Thanks for the perf numbers. It sounds like it's good enough to switch to it in the future to me. |
Thanks! |
Description
babelPlugins
andtsPluginOptions
optionsAdditional context
In the original issue description the proposed new option
tsTransform
had values'esbuild'
and'babel'
. In the PR the'esbuild'
value was renamed to'built-in'
because it describes semantics more clearly andvite
is planning to integraterolldown
asesbuild
replacement.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).