Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL Query Params are encoded due to buggy version of normalize-url #84

Open
aashutoshrathi opened this issue Aug 25, 2022 · 1 comment
Open

URL Query Params are encoded due to buggy version of normalize-url #84

aashutoshrathi opened this issue Aug 25, 2022 · 1 comment
Labels
bug dependencies Pull requests that update a dependency file good first issue help wanted

Comments

@aashutoshrathi
Copy link

We currently use https://github.com/sindresorhus/normalize-url ^4.5.1 to normalize URLs and it's buggy.
The bug is simple that, they don't decode back the queryParameters after it's encode as side-effect of sort().

Fixed later here: sindresorhus/normalize-url#158

Solution: Upgrade to newer version of normalize-url
@visualjerk visualjerk added bug help wanted good first issue dependencies Pull requests that update a dependency file labels Aug 25, 2022
@aashutoshrathi
Copy link
Author

aashutoshrathi commented Aug 25, 2022 •
edited
Loading

There is one issue though, normalize-url went to Full ESM only in v7.0.0 and the issue was fixed in the latest version i.e v7.0.3
cc: @visualjerk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug dependencies Pull requests that update a dependency file good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aashutoshrathi @visualjerk