Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading save of windowLayout in GlobalAttributes section of config #19917

Open
markcmiller86 opened this issue Oct 18, 2024 · 0 comments
Open
Labels
bug Something isn't working impact medium Productivity partially degraded (not easily mitigated bug) or improved (enhancement) likelihood medium Neither low nor high likelihood

Comments

@markcmiller86
Copy link
Member

Describe the bug

This line in a .config file is totally ignored by VisIt. It should not be saved.

                <Field name="windowLayout" type="int">9</Field>

The real stuff in the .config file that drives how windows come up when VisIt is started is down near the bottom of the file where it outputs ViewerWindowManager and includes a list of windows...

            <Object name="ViewerWindowManager">
                <Object name="SelectionList">
                </Object>
                <Field name="cameraView" type="bool">false</Field>
                <Field name="viewExtentsType" type="string">AVT_ORIGINAL_EXTENTS</Field>
                <Object name="Windows">
                    <Object name="ViewerWindow">
                        <Field name="windowSize" type="intArray" length="2">1150 1147 </Field>
                        <Field name="windowImageSize" type="intArray" length="2">1150 1083 </Field>
                        <Field name="windowLocation" type="intArray" length="2">403 25 </Field>
                    </Object>
                    <Object name="ViewerWindow">
                        <Field name="windowSize" type="intArray" length="2">757 757 </Field>
                        <Field name="windowImageSize" type="intArray" length="2">757 693 </Field>
                        <Field name="windowLocation" type="intArray" length="2">1161 25 </Field>
                        <Field name="maintainView" type="bool">false</Field>
                    </Object>
                    .
                    .
                    .

That said, upon restart, VisIt will not return the windows to their original state before the settings were saved. It will create the windows but they will not fit nicely into their respective places on the screen as setting a layout would actually do.

It might be nice for ViewerWindowManager:SetFromNode to call ViewerWindowManager:SetWindowLayout upon setting up all the windows. The challenge is, it cannot really know which layout might be correct. It would have to use heuristics and guess. The user could have set a layout and then deleted a window or two or resized a window or two, etc. I suppose if after setting a layout, no windows were added or deleted and no windows were resized, then it might be ok to include information in .config what the layout id is and that it is clean and then restoring could set that layout again.

@markcmiller86 markcmiller86 added bug Something isn't working likelihood medium Neither low nor high likelihood impact medium Productivity partially degraded (not easily mitigated bug) or improved (enhancement) labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working impact medium Productivity partially degraded (not easily mitigated bug) or improved (enhancement) likelihood medium Neither low nor high likelihood
Projects
None yet
Development

No branches or pull requests

1 participant