Skip to content

Commit 595b0e4

Browse files
Don McCurdydonmccurdy
authored andcommitted
Update ArcLayer, LineLayer, PolygonLayer to GLSL 300
1 parent 8d0448b commit 595b0e4

File tree

9 files changed

+76
-63
lines changed

9 files changed

+76
-63
lines changed

modules/extensions/src/fill-style/shaders.glsl.ts

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -17,16 +17,16 @@ const patternVs = `
1717
#define FILL_PATTERN_OFFSET_ATTRIB instanceFillPatternOffsets
1818
#endif
1919
20-
attribute vec4 FILL_PATTERN_FRAME_ATTRIB;
21-
attribute float FILL_PATTERN_SCALE_ATTRIB;
22-
attribute vec2 FILL_PATTERN_OFFSET_ATTRIB;
20+
in vec4 FILL_PATTERN_FRAME_ATTRIB;
21+
in float FILL_PATTERN_SCALE_ATTRIB;
22+
in vec2 FILL_PATTERN_OFFSET_ATTRIB;
2323
2424
uniform bool fill_patternEnabled;
2525
uniform vec2 fill_patternTextureSize;
2626
27-
varying vec2 fill_uv;
28-
varying vec4 fill_patternBounds;
29-
varying vec4 fill_patternPlacement;
27+
out vec2 fill_uv;
28+
out vec4 fill_patternBounds;
29+
out vec4 fill_patternPlacement;
3030
`;
3131

3232
const patternFs = `
@@ -36,9 +36,9 @@ uniform sampler2D fill_patternTexture;
3636
uniform vec2 fill_uvCoordinateOrigin;
3737
uniform vec2 fill_uvCoordinateOrigin64Low;
3838
39-
varying vec4 fill_patternBounds;
40-
varying vec4 fill_patternPlacement;
41-
varying vec2 fill_uv;
39+
in vec4 fill_patternBounds;
40+
in vec4 fill_patternPlacement;
41+
in vec2 fill_uv;
4242
4343
const float FILL_UV_SCALE = 512.0 / 40000000.0;
4444
`;
@@ -64,7 +64,7 @@ const inject = {
6464
6565
vec2 texCoords = fill_patternBounds.xy + fill_patternBounds.zw * patternUV;
6666
67-
vec4 patternColor = texture2D(fill_patternTexture, texCoords);
67+
vec4 patternColor = texture(fill_patternTexture, texCoords);
6868
color.a *= patternColor.a;
6969
if (!fill_patternMask) {
7070
color.rgb = patternColor.rgb;

modules/layers/src/arc-layer/arc-layer-fragment.glsl.ts

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,22 +19,25 @@
1919
// THE SOFTWARE.
2020

2121
export default `\
22+
#version 300 es
2223
#define SHADER_NAME arc-layer-fragment-shader
2324
2425
precision highp float;
2526
26-
varying vec4 vColor;
27-
varying vec2 uv;
28-
varying float isValid;
27+
in vec4 vColor;
28+
in vec2 uv;
29+
in float isValid;
30+
31+
out vec4 fragColor;
2932
3033
void main(void) {
3134
if (isValid == 0.0) {
3235
discard;
3336
}
3437
35-
gl_FragColor = vColor;
38+
fragColor = vColor;
3639
geometry.uv = uv;
3740
38-
DECKGL_FILTER_COLOR(gl_FragColor, geometry);
41+
DECKGL_FILTER_COLOR(fragColor, geometry);
3942
}
4043
`;

modules/layers/src/arc-layer/arc-layer-vertex.glsl.ts

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -19,19 +19,20 @@
1919
// THE SOFTWARE.
2020

2121
export default `\
22+
#version 300 es
2223
#define SHADER_NAME arc-layer-vertex-shader
2324
24-
attribute vec3 positions;
25-
attribute vec4 instanceSourceColors;
26-
attribute vec4 instanceTargetColors;
27-
attribute vec3 instanceSourcePositions;
28-
attribute vec3 instanceSourcePositions64Low;
29-
attribute vec3 instanceTargetPositions;
30-
attribute vec3 instanceTargetPositions64Low;
31-
attribute vec3 instancePickingColors;
32-
attribute float instanceWidths;
33-
attribute float instanceHeights;
34-
attribute float instanceTilts;
25+
in vec3 positions;
26+
in vec4 instanceSourceColors;
27+
in vec4 instanceTargetColors;
28+
in vec3 instanceSourcePositions;
29+
in vec3 instanceSourcePositions64Low;
30+
in vec3 instanceTargetPositions;
31+
in vec3 instanceTargetPositions64Low;
32+
in vec3 instancePickingColors;
33+
in float instanceWidths;
34+
in float instanceHeights;
35+
in float instanceTilts;
3536
3637
uniform bool greatCircle;
3738
uniform bool useShortestPath;
@@ -42,9 +43,9 @@ uniform float widthMinPixels;
4243
uniform float widthMaxPixels;
4344
uniform int widthUnits;
4445
45-
varying vec4 vColor;
46-
varying vec2 uv;
47-
varying float isValid;
46+
out vec4 vColor;
47+
out vec2 uv;
48+
out float isValid;
4849
4950
float paraboloid(float distance, float sourceZ, float targetZ, float ratio) {
5051
// d: distance on the xy plane

modules/layers/src/line-layer/line-layer-fragment.glsl.ts

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,18 +19,21 @@
1919
// THE SOFTWARE.
2020

2121
export default `\
22+
#version 300 es
2223
#define SHADER_NAME line-layer-fragment-shader
2324
2425
precision highp float;
2526
26-
varying vec4 vColor;
27-
varying vec2 uv;
27+
in vec4 vColor;
28+
in vec2 uv;
29+
30+
out vec4 fragColor;
2831
2932
void main(void) {
3033
geometry.uv = uv;
3134
32-
gl_FragColor = vColor;
35+
fragColor = vColor;
3336
34-
DECKGL_FILTER_COLOR(gl_FragColor, geometry);
37+
DECKGL_FILTER_COLOR(fragColor, geometry);
3538
}
3639
`;

modules/layers/src/line-layer/line-layer-vertex.glsl.ts

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -19,16 +19,17 @@
1919
// THE SOFTWARE.
2020

2121
export default `\
22+
#version 300 es
2223
#define SHADER_NAME line-layer-vertex-shader
2324
24-
attribute vec3 positions;
25-
attribute vec3 instanceSourcePositions;
26-
attribute vec3 instanceTargetPositions;
27-
attribute vec3 instanceSourcePositions64Low;
28-
attribute vec3 instanceTargetPositions64Low;
29-
attribute vec4 instanceColors;
30-
attribute vec3 instancePickingColors;
31-
attribute float instanceWidths;
25+
in vec3 positions;
26+
in vec3 instanceSourcePositions;
27+
in vec3 instanceTargetPositions;
28+
in vec3 instanceSourcePositions64Low;
29+
in vec3 instanceTargetPositions64Low;
30+
in vec4 instanceColors;
31+
in vec3 instancePickingColors;
32+
in float instanceWidths;
3233
3334
uniform float opacity;
3435
uniform float widthScale;
@@ -37,8 +38,8 @@ uniform float widthMaxPixels;
3738
uniform float useShortestPath;
3839
uniform int widthUnits;
3940
40-
varying vec4 vColor;
41-
varying vec2 uv;
41+
out vec4 vColor;
42+
out vec2 uv;
4243
4344
// offset vector by strokeWidth pixels
4445
// offset_direction is -1 (left) or 1 (right)

modules/layers/src/solid-polygon-layer/solid-polygon-layer-fragment.glsl.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,18 @@
1919
// THE SOFTWARE.
2020

2121
export default `\
22+
#version 300 es
2223
#define SHADER_NAME solid-polygon-layer-fragment-shader
2324
2425
precision highp float;
2526
26-
varying vec4 vColor;
27+
in vec4 vColor;
28+
29+
out vec4 fragColor;
2730
2831
void main(void) {
29-
gl_FragColor = vColor;
32+
fragColor = vColor;
3033
31-
DECKGL_FILTER_COLOR(gl_FragColor, geometry);
34+
DECKGL_FILTER_COLOR(fragColor, geometry);
3235
}
3336
`;

modules/layers/src/solid-polygon-layer/solid-polygon-layer-vertex-main.glsl.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ uniform bool isWireframe;
2525
uniform float elevationScale;
2626
uniform float opacity;
2727
28-
varying vec4 vColor;
28+
out vec4 vColor;
2929
3030
struct PolygonProps {
3131
vec4 fillColors;

modules/layers/src/solid-polygon-layer/solid-polygon-layer-vertex-side.glsl.ts

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -21,19 +21,20 @@
2121
import main from './solid-polygon-layer-vertex-main.glsl';
2222

2323
export default `\
24+
#version 300 es
2425
#define SHADER_NAME solid-polygon-layer-vertex-shader-side
2526
26-
attribute vec2 positions;
27+
in vec2 positions;
2728
28-
attribute vec3 instancePositions;
29-
attribute vec3 instanceNextPositions;
30-
attribute vec3 instancePositions64Low;
31-
attribute vec3 instanceNextPositions64Low;
32-
attribute float instanceElevations;
33-
attribute vec4 instanceFillColors;
34-
attribute vec4 instanceLineColors;
35-
attribute vec3 instancePickingColors;
36-
attribute float instanceVertexValid;
29+
in vec3 instancePositions;
30+
in vec3 instanceNextPositions;
31+
in vec3 instancePositions64Low;
32+
in vec3 instanceNextPositions64Low;
33+
in float instanceElevations;
34+
in vec4 instanceFillColors;
35+
in vec4 instanceLineColors;
36+
in vec3 instancePickingColors;
37+
in float instanceVertexValid;
3738
3839
${main}
3940

modules/layers/src/solid-polygon-layer/solid-polygon-layer-vertex-top.glsl.ts

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,15 @@
2121
import main from './solid-polygon-layer-vertex-main.glsl';
2222

2323
export default `\
24+
#version 300 es
2425
#define SHADER_NAME solid-polygon-layer-vertex-shader
2526
26-
attribute vec3 vertexPositions;
27-
attribute vec3 vertexPositions64Low;
28-
attribute float elevations;
29-
attribute vec4 fillColors;
30-
attribute vec4 lineColors;
31-
attribute vec3 pickingColors;
27+
in vec3 vertexPositions;
28+
in vec3 vertexPositions64Low;
29+
in float elevations;
30+
in vec4 fillColors;
31+
in vec4 lineColors;
32+
in vec3 pickingColors;
3233
3334
${main}
3435

0 commit comments

Comments
 (0)