Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analytics tags in sources #1214

Open
ojas1 opened this issue Jul 3, 2020 · 1 comment
Open

Analytics tags in sources #1214

ojas1 opened this issue Jul 3, 2020 · 1 comment
Assignees
@mrudhvika940

Comments

@ojas1
Copy link
Contributor

ojas1 commented Jul 3, 2020

The analytics script changes the source files in-place to insert analytics related tags. This script is supposed to be executed at build time. The changes made by this script should not be committed to the repository. However, these changes have been committed to master. As a result, the analytics script would have no effect in the future until these are not reverted.
@priya100raman
Copy link

@mrudhvika940 please revert the changes made and make note of the issue. Please check if this has been done for any other labs as well. Please ensure that all code is reviewed before check-in so this kind of thing doesn't happen

@priya100raman priya100raman removed their assignment Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrudhvika940 mrudhvika940

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ojas1 @mrudhvika940 @priya100raman