-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: support different versions of systemd #68
Comments
I think most of these are not essential, so we can live without if we detect older systemds. The ReadOnly* ones are nice to have though. OTOH, even I have access to RHEL8 machines... |
The hard part is to find a feature matrix to determine what attributes are available per version. If we had that, it would be easy to implement this. I need to do some digging because there's demand for RHEL 7 support :) |
Even better would be to probe for support, but harder |
I don't think systemd even does that, does it? |
[ Quoting <notifications@github.com> in "Re: [virtual-kubelet/systemk] featu..." ]
I don't think systemd even does that, does it?
don't know. You said you got an error, is that detectable from within systemk?
We could just barf out dummy units and see what happens
|
I just saw these in journal logs, when parsing the unit, eg
|
[ Quoting <notifications@github.com> in "Re: [virtual-kubelet/systemk] featu..." ]
I just saw these in journal logs, when parsing the unit, eg
Unknown lvalue 'PrivateUsers' in section 'Service'
ugh, silently drops it #sigh
|
[ Quoting <notifications@github.com> in "Re: [virtual-kubelet/systemk] featu..." ]
I just saw these in journal logs, when parsing the unit, eg
Unknown lvalue 'PrivateUsers' in section 'Service'
there is `systemd-run` which takes a unit as argument, I would assume that actually errors
when giving it the wrong thing?
|
[ Quoting <notifications@github.com> in "Re: [virtual-kubelet/systemk] featu..." ]
I just saw these in journal logs, when parsing the unit, eg
Unknown lvalue 'PrivateUsers' in section 'Service'
% systemd-run -p PublicTmp=no ls
Unknown assignment: PublicTmp=no
% echo $?
1
|
If the CLI does it, then maybe there's an API behind it? I'm not supportive of wrapping CLI because that's not a contract I trust in. |
Maybe? Doesn't matter for our API as we can swap it later. Getting some
means of detecting and making that code easy and elegant is my goal for now
…On Fri, 22 Jan 2021, 18:22 Pires, ***@***.***> wrote:
If the CLI does it, then maybe there's an API behind it? I'm not
supportive of wrapping CLI because that's not a contract I trust in.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#68 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACWIW2DDCXQTHLH2NOZEBDS3GX5LANCNFSM4WNG7KGQ>
.
|
Regardless how we probe: this is what I had in mind: #74 |
For instance, in RHEL7 (systemd 219), user-mode systemd doesn't seem to be a thing. Also, certain unit attributes we populate today are unsupported, such as:
BindReadOnlyPaths
PrivateMounts
ReadOnlyPaths
TemporaryFileSystem
I understand older distros may not be a goal but if we want this project to be used on bigger companies, we'll have to account for this.
The text was updated successfully, but these errors were encountered: