-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend] Add GUI with input fields for range + CTAs for scanning network #12
Comments
@Kashish121, @ishika1727 - Any thoughts here? |
Looks great, will ping a few ideas while working on it. |
Amazing, excited to work on it. |
@Kashish121 Changed the directory structure and updated the steps in @ishika1727 Please rebase your |
On it. |
1 similar comment
On it. |
No issues. PortScanner can be run easily following the steps mentioned in |
TODOas discussed in meeting @ishika1727 - Explore materialize Post your thoughts here for the wireframe. |
From now onwards, we'll track our progress here. @Kashish121 , @ishika1727 - Check out the Project board. |
@vinitshahdeo Please review this UI |
@ishika1727 Few suggestions from my end:
|
@vinitshahdeo I have made the required changes. Please review it. |
@vinitshahdeo thank you for tagging me! :) Yes, I'd love to! And you have already made some key observations regarding the functionality of it. @ishika1727 Okay so a couple of things, I think the page lacks design. I do understand that this is just a utility tool but, maybe give the user an experience and interphase they'll always remember. So instead of having it route to contact and about, there's actually ample space to accommodate all of your content in the same page, of course with a smart use of drop downs in the mobile UI. So maybe consider that as well :) For the current design:
And lastly, I would suggest using a wireframing tool or software like figma when you guys are going back and forth with designs since there are bound to be many versions before you actually settle with one and it puts way too much work on the person building it. I don't know if you guys have already done that but this is just a suggestion it would make working as a team and collaborating a lot more smoother. Hope this helps :) |
@nainikaB Wow, this is an intensive review! ❤️
|
@ishika1727, Center align the GitHub logo in sidebar and let's change the color of icon to the theme color. Rest we can discuss over the call. |
@vinitshahdeo ayeee please don't thank me, happy to be of any kind of help with your project. :) Although, I think I might have increased the work load, sorry! If you guys are on a strict time constraint ignore the complete rearranging of elements that I suggested and instead, maybe improvise with the current design itself along with the comments I have attached above and anything else that I might have missed. And yes, I'll definitely keep an eye here and help you guys with anything else you might need :) Yes that's true, Figma does take time definitely not advisable when you have a deadline approaching. |
@nainikaB 😊 Will ensure that the UI bit includes all of your suggestions. Thanks for being kind, as always! Keep guiding! ✌️ |
[ Frontend / TODO ] @ishika1727 Here's sharing a few utilities which you can use to finalize the fonts. Use a combo of three font-families - heading, sub-heading and paragraph.
Check colorhunt.co to get inspiration for color palletes. @Kashish121 Join her and finalize the font and theme color for the website. |
[ Deliverables by Sunday EOD ]
|
@vinitshahdeo, Working on it already. 👍 Will share the updates. |
Doing the required changes. Will create a PR soon |
@ishika1727 & @Kashish121 - Any updates? Let's sync up and finish the pending tasks. |
Hey @vinitshahdeo , got the required changes in the UI today. Will push the the code for connectivity tomorrow. |
@vinitshahdeo already created a PR yesterday with the changes you suggested. |
@ishika1727 Added few comments on #39 |
@Kashish121 / @ishika1727 - Please try running this locally and confirm me.
|
Works for me @vinitshahdeo . @ishika1727 can you confirm once? |
works for me too |
Is this open ? I would like to make an GUI interface using PyQt5. |
Hey @Sohaib03, thanks for showing your interest. Please go ahead. PS: The website is done but let's have Desktop GUI too. |
I will be using PyQt5 with Python 3. Is that okay ? Or i should use Python 2 ? |
@Sohaib03 That's fine. Just ensure that you branch off from correct branch ( |
@Sohaib03 This looks great. 🤩 👏 cc: @Kashish121 / @ishika1727 |
Thanks. I am working on it. |
I want to make a pull request. Do you want to review the code ? |
@Sohaib03 Yes, please raise the PR. |
Currently this is a CLI based application, convert this into a GUI application to make the UX better!
Must have:
Good to have:
Extended feature
PS: Still open for discussions - feel free to suggest GUI frameworks(preferably from Python).
The text was updated successfully, but these errors were encountered: