From bdbc372658f4eeb45fc15a3dc535e32c12d23d26 Mon Sep 17 00:00:00 2001 From: Vini Salazar <17276653+vinisalazar@users.noreply.github.com> Date: Wed, 30 Nov 2022 12:58:44 +1100 Subject: [PATCH] Removing more ** from methods - Code review for #280 --- erddapy/core/interfaces.py | 6 +++--- erddapy/core/netcdf.py | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/erddapy/core/interfaces.py b/erddapy/core/interfaces.py index 305869c8..deb1f8ee 100644 --- a/erddapy/core/interfaces.py +++ b/erddapy/core/interfaces.py @@ -57,7 +57,7 @@ def to_ncCF( ) if requests_kwargs is None: requests_kwargs = {} - return _nc_dataset(url, **requests_kwargs) + return _nc_dataset(url, requests_kwargs) def to_xarray( @@ -81,7 +81,7 @@ def to_xarray( if response == "opendap": return xr.open_dataset(url, **xarray_kwargs) else: - nc = _nc_dataset(url, **requests_kwargs) + nc = _nc_dataset(url, requests_kwargs) return xr.open_dataset(xr.backends.NetCDF4DataStore(nc), **xarray_kwargs) @@ -101,7 +101,7 @@ def to_iris( requests_kwargs = {} if iris_kwargs is None: iris_kwargs = {} - data = urlopen(url, **requests_kwargs) + data = urlopen(url, requests_kwargs) with _tempnc(data) as tmp: cubes = iris.load_raw(tmp, **iris_kwargs) _ = [cube.data for cube in cubes] diff --git a/erddapy/core/netcdf.py b/erddapy/core/netcdf.py index 768adf8b..5ae7616f 100644 --- a/erddapy/core/netcdf.py +++ b/erddapy/core/netcdf.py @@ -2,14 +2,14 @@ from contextlib import contextmanager from pathlib import Path -from typing import Dict, Generator +from typing import Dict, Generator, Optional from typing.io import BinaryIO from urllib.parse import urlparse from erddapy.core.url import urlopen -def _nc_dataset(url, **requests_kwargs: Dict): +def _nc_dataset(url, requests_kwargs: Optional[Dict] = None): """Return a netCDF4-python Dataset from memory and fallbacks to disk if that fails.""" from netCDF4 import Dataset