Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Found bug in gem5/src/mem/abstract_mem.cc #19

Open
anaarduengo opened this issue Aug 20, 2020 · 1 comment
Open

Found bug in gem5/src/mem/abstract_mem.cc #19

anaarduengo opened this issue Aug 20, 2020 · 1 comment

Comments

@anaarduengo
Copy link

I have not been able to run the simulator, but I was having a look at the code and I saw the following in line 458 of the file gem5/src/mem/abstract_mem.cc

for(auto i=pendingPIMqueue.begin();i!=pendingPIMqueue.end();i++){
    if((*i)->addr[0]==senderState->addr[0]&&(*i)->addr[0]==senderState->addr[0]&&(*i)->addr[0]==senderState->addr[0]){
        found=true;
        index=i;
        threadid=(*i)->threadid;
        break;
    
    }
 }

The condition of the if repeats three times, I think it should be checking that the positions 0, 1 and 2 of the addr vector are the same as the ones of the addr vector in the SenderState.

@NabiiBux
Copy link

NabiiBux commented Jun 24, 2021

Tell me which software you are using for the simulation of gem5 and pim simulation
Help me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants