Skip to content

Commit 1b7b176

Browse files
janicduplessisfacebook-github-bot
authored andcommitted
Use react.gradle from repo root instead of copy in RNTester
Summary: RNTester used a copy of the main react.gradle file instead of the real one. Recent changes to the real file caused builds to fail with older gradle versions but was not caught by CI because it wasn't using that file for RNTester. That copy of react.gradle is just a leftover from when projects included a copy instead of importing the one in RN directly. Note: CI WILL fail with this PR, if we have trouble landing this I can add the revert in this commit too but wanted to keep it as 2 separate commits. Tested that building RNTester actually fails now that it uses react.gradle with recent changes, then tested that is builds properly when reverting d16ff3bd8b92fa84a9007bf5ebedd8153e4c089d. [INTERNAL] [MINOR] [RNTester] - Use react.gradle from repo root instead of copy in RNTester Closes facebook/react-native#18188 Differential Revision: D7155179 Pulled By: hramos fbshipit-source-id: 15b461a63b841bf807e7d11ba3ead005ca5e33b0
1 parent 9d61ad0 commit 1b7b176

File tree

2 files changed

+1
-97
lines changed

2 files changed

+1
-97
lines changed

android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ project.ext.react = [
6464
inputExcludes: ["android/**", "./**"]
6565
]
6666

67-
apply from: "react.gradle"
67+
apply from: "../../../react.gradle"
6868

6969
/**
7070
* Set this to true to create three separate APKs instead of one:

android/app/react.gradle

Lines changed: 0 additions & 96 deletions
This file was deleted.

0 commit comments

Comments
 (0)