Skip to content

Commit

Permalink
Remove unnecessary Iterator loop in history.get (#517)
Browse files Browse the repository at this point in the history
This seems to be not necessary and it is causing issues particularly in
firefox 47, there query is a "XPCWrappedNative_NoHelper" and we can't
modify it which is what this loop tries to do.
Wrapping it in a try/catch does fix the issue as well but removing it
altogether seems to also fix it and seems that there are no adverse
effects.
  • Loading branch information
gkatsev committed May 19, 2016
1 parent e65a566 commit afe333b
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions common/content/history.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ const History = Module("history", {

if (typeof filter == "string")
filter = { searchTerms: filter };
for (let [k, v] in Iterator(filter))
query[k] = v;

options.sortingMode = options.SORT_BY_DATE_DESCENDING;
options.resultType = options.RESULTS_AS_URI;
if (maxItems > 0)
Expand Down

0 comments on commit afe333b

Please sign in to comment.