Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete type aliases for int type #8118

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Complete type aliases for int type #8118

wants to merge 2 commits into from

Conversation

BruceGitHub
Copy link

No description provided.

@BruceGitHub
Copy link
Author

BruceGitHub commented Jun 16, 2022 •
edited
Loading

Beside the test, Which other point I should to change
@AndrolGenhald only for this alias ...

@AndrolGenhald
Copy link
Collaborator

AndrolGenhald commented Jun 16, 2022 •
edited
Loading

Do you mind adding negative-int and non-positive-int as well (@orklah I assume we want these?)?

  • Add it under Scalar Types in atomic_types.md (put it next to positive-int)
  • Add a section in scalar_types.md next to the positive-int section
  • Add some sort of test just to make sure there's no blatant failure, maybe do something like what already exists for positive-int in TypeCombinationTest.php
  • Change the PR title to something descriptive like "Add non-negative-int type" (PR titles are included in the changelog)

@AndrolGenhald AndrolGenhald added the release:feature The PR will be included in 'Features' section of the release notes label Jun 16, 2022
@BruceGitHub BruceGitHub changed the title first changes for non-negative-int Complete type aliases for int type Jun 16, 2022
@BruceGitHub
Copy link
Author

I'm busy, but soon
I will return back... to complete this task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release:feature The PR will be included in 'Features' section of the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BruceGitHub @AndrolGenhald