-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expected psalm suppression time? #9918
Comments
Hey @ro0NL, can you reproduce the issue on https://psalm.dev ? |
Unfortunately, I have no answer to your main question. However, i can say that --set-baseline makes --update-baseline redundant (the first one recreate the baseline completely while the second one only adds new issues in the existing baseline). Maybe using only the one you need would change something? |
unfortunately it doesnt make any difference, but removed --update-baseline either way the bottleneck is definitely --set-baseline, since without it but with the same cache, i get instant errors after modifying a file so we need 2m for some baseline file IO 🤔 |
it seems the cache is just ignored/invalidated when using --set-baseline looking at --debug output, i see a lot of |
im gonna assume things happen for some reason |
Hi,
We're running psalm in GitHub actions.
On our develop branch we suppress any issue 😬
The command running is:
psalm --no-progress --output-format=github --set-baseline=psalm-baseline.xml --update-baseline
Initially ~40 MB of cache was successfully restored.
The runtime takes about ~2m, for a commit that didnt do any code changes. It's actually about the same time a commit with few code changes takes.
Is this expected, or am i missing something?
The text was updated successfully, but these errors were encountered: