Improve test setup

Signed-off-by: Vikram Vaswani <112123850+vikram-dagger@users.noreply.github.com>

Author: vikram-dagger

conftest.py

@@ -1,3 +1,4 @@
+
 import pytest
 from sqlalchemy import create_engine, inspect
 from sqlalchemy.orm import sessionmaker
@@ -6,6 +7,12 @@
 from .dependencies import get_db, database_url
 from .models import Base
 
+@pytest.fixture(autouse=True)
+def clean_books_table(test_db):
+    """Truncate books table before each test to avoid unique constraint errors."""
+    test_db.execute("TRUNCATE TABLE books RESTART IDENTITY CASCADE;")
+    test_db.commit()
+
 @pytest.fixture(scope="session")
 def test_engine():
     """Create test database engine"""

db.sql

@@ -1,4 +1,4 @@
-DROP TABLE books;
+DROP TABLE IF EXISTS books;
 
 CREATE TABLE books (
     id SERIAL PRIMARY KEY,

docker-compose.yml

@@ -8,12 +8,15 @@ services:
     environment:
       - DATABASE_URL=postgresql://app_user:secret@db/app_db
     depends_on:
-      - db
+      db:
+        condition: service_healthy
+    networks:
+      - app_network
 
   db:
-    image: postgres:15
+    image: postgres:15-alpine
     container_name: fastapi_db
-    restart: always
+    restart: unless-stopped
     environment:
       POSTGRES_DB: app_db
       POSTGRES_USER: app_user
@@ -22,7 +25,19 @@ services:
       - "5432:5432"
     volumes:
       - postgres_data:/var/lib/postgresql/data
-      - ./db.sql:/docker-entrypoint-initdb.d/db.sql
+    healthcheck:
+      test: ["CMD-SHELL", "pg_isready -U app_user -d app_db"]
+      interval: 10s
+      timeout: 5s
+      retries: 5
+      start_period: 10s
+    networks:
+      - app_network
+
+networks:
+  app_network:
+    driver: bridge
 
 volumes:
   postgres_data:
+    driver: local

test_main.py

@@ -1,7 +1,6 @@
 from .repositories import create_book, get_books, get_book, update_book, delete_book
 from .models import BookIn
 from sqlalchemy import create_engine, inspect
-# from . import TEST_BOOKS
 
 # Test data constants
 TEST_BOOKS = [