Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading warning message when no pages have been setup yet #2045

Closed
f0x52 opened this issue Jan 2, 2025 · 1 comment
Closed

Misleading warning message when no pages have been setup yet #2045

f0x52 opened this issue Jan 2, 2025 · 1 comment
Labels

Comments

@f0x52
Copy link
Contributor

f0x52 commented Jan 2, 2025

Description

I'm trying out Vite + Vike for the first time, integrating it in an existing project by following https://vike.dev/add, running the server as I went along to ensure stuff worked.
Before step 4, this lead to me chasing the following warning:

[vike][Warning] Update to the new V1 design to get rid of Vite's warning: The glob option "as" has been deprecated in favour of "query". See https://vike.dev/migration/v1-design for how to migrate.
The glob option "as" has been deprecated in favour of "query". Please update as: 'extractExportNames' to query: '?extractExportNames'.

After digging through the code, I eventually found out this was due to the config.pageConfigs list being empty, (because I hadn't done step 4 yet).
Maybe there is another heuristic that can be used to find pre-V1 configs, which doesn't also trigger on partly set-up/empty projects (which are otherwise following V1 design)?
Or if there isn't, something could be added to the warning, explaining that this also comes up if you haven't configured any pages yet.

@f0x52 f0x52 added the bug 💥 label Jan 2, 2025
@brillout
Copy link
Member

brillout commented Jan 2, 2025

Indeed, the warning's heuristic is faulty and I'm actually aware of that. The old design is going to be removed very soon so this will resolve itself very soon (ETA Q1). Thus closing. Thank you for reaching out about this; let us know if you stumble upon other paper cuts like this.

@brillout brillout closed this as not planned Won't fix, can't repro, duplicate, stale Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants