use multiple values under the same key from the body (fixes joestump#23)

Thanks to rogerm, ideasculptor, jiivan, timgraham.

Author: zookos

oauth2/__init__.py

@@ -31,7 +31,7 @@
 import binascii
 import httplib2
 
-from urlparse import parse_qs, parse_qsl
+from urlparse import parse_qs
 
 try:
     from hashlib import sha1
@@ -627,7 +627,7 @@ def request(self, uri, method="GET", body='', headers=None,
             headers.get('Content-Type') == 'application/x-www-form-urlencoded'
 
         if is_form_encoded and body:
-            parameters = dict(parse_qsl(body))
+            parameters = parse_qs(body)
         else:
             parameters = None
 

tests/test_oauth.py

@@ -1212,6 +1212,21 @@ def mockrequest(cl, ur, **kw):
 
         client.request(uri, 'GET')
 
+    @mock.patch('httplib2.Http.request')
+    @mock.patch('oauth2.Request.from_consumer_and_token')
+    def test_multiple_values_for_a_key(self, mockReqConstructor, mockHttpRequest):
+        client = oauth.Client(self.consumer, None)
+
+        request = oauth.Request("GET", "http://example.com/fetch.php", parameters={'multi': ['1', '2']})
+        mockReqConstructor.return_value = request
+
+        client.request('http://whatever', 'POST', body='multi=1&multi=2')
+
+        self.failUnlessEqual(mockReqConstructor.call_count, 1)
+        self.failUnlessEqual(mockReqConstructor.call_args[1]['parameters'], {'multi': ['1', '2']})
+
+        self.failUnless('multi=1' in mockHttpRequest.call_args[1]['body'])
+        self.failUnless('multi=2' in mockHttpRequest.call_args[1]['body'])
+
 if __name__ == "__main__":
     unittest.main()
-