Skip to content

Commit 562264a

Browse files
author
Victor LOIZEL
committed
wip
1 parent 7d4ded7 commit 562264a

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

src/main/java/issue/spring/graphql/objectlist/EntityController.java renamed to src/main/java/issue/spring/graphql/objectlist/BusinessEntityController.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@
77
import java.util.List;
88

99
@Controller
10-
public class EntityController {
10+
public class BusinessEntityController {
1111

1212
@QueryMapping
13-
public boolean filterValueIsInstanceOfList(@Argument EntityFilterInput filter) {
13+
public boolean filterValueIsInstanceOfList(@Argument BusinessEntityFilterInput filter) {
1414
return filter.getValue() instanceof List;
1515
}
1616
}

src/main/java/issue/spring/graphql/objectlist/EntityFilterInput.java renamed to src/main/java/issue/spring/graphql/objectlist/BusinessEntityFilterInput.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
package issue.spring.graphql.objectlist;
22

3-
public class EntityFilterInput {
3+
public class BusinessEntityFilterInput {
44
private String operator;
55
private Object value;
66

77
public String getOperator() {
88
return operator;
99
}
1010

11-
public EntityFilterInput setOperator(String operator) {
11+
public BusinessEntityFilterInput setOperator(String operator) {
1212
this.operator = operator;
1313
return this;
1414
}
@@ -17,7 +17,7 @@ public Object getValue() {
1717
return value;
1818
}
1919

20-
public EntityFilterInput setValue(Object value) {
20+
public BusinessEntityFilterInput setValue(Object value) {
2121
this.value = value;
2222
return this;
2323
}

src/test/java/issue/spring/graphql/objectlist/EntityControllerTests.java renamed to src/test/java/issue/spring/graphql/objectlist/BusinessEntityControllerTests.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@
99
import java.util.List;
1010
import java.util.Map;
1111

12-
@GraphQlTest(EntityController.class)
12+
@GraphQlTest(BusinessEntityController.class)
1313
@Import(GraphQlConfig.class)
14-
public class EntityControllerTests {
14+
public class BusinessEntityControllerTests {
1515

1616
@Autowired
1717
private GraphQlTester graphQlTester;
@@ -20,7 +20,7 @@ public class EntityControllerTests {
2020
* Works with a {@link String} in {@link Object} type (cast OK)
2121
*/
2222
@Test
23-
void filterValueIsInstanceOfList_ok() {
23+
void filterValueIsInstanceOfList_stringValue() {
2424
final Map<String, Object> value = Map.of(
2525
"operator", "operator",
2626
"value", "value"
@@ -39,7 +39,7 @@ void filterValueIsInstanceOfList_ok() {
3939
* we have an {@link graphql.language.ArrayValue} in {@link Object}, shall we have a List instead ?
4040
*/
4141
@Test
42-
void filterValueIsInstanceOfList_ko() {
42+
void filterValueIsInstanceOfList_withoutVariables() {
4343
this.graphQlTester.documentName("filterValueIsInstanceOfList_withoutVariables")
4444
.execute()
4545
.path("filterValueIsInstanceOfList")
@@ -52,7 +52,7 @@ void filterValueIsInstanceOfList_ko() {
5252
* org.springframework.beans.InvalidPropertyException: Invalid property 'value[0]' of bean class [issue.spring.graphql.objectlist.EntityFilterInput]: Property referenced in indexed property path 'value[0]' is neither an array nor a List nor a Map; returned value was [java.lang.Object@7841bd30]
5353
*/
5454
@Test
55-
void filterValueIsInstanceOfList_ko2() {
55+
void filterValueIsInstanceOfList_withException() {
5656
final Map<String, Object> value = Map.of(
5757
"operator", "operator",
5858
"value", List.of("value1", "value2")

0 commit comments

Comments
 (0)