Skip to content

Commit 34c590f

Browse files
Jonah Williamsvictorsanni
authored andcommitted
[flutter_driver] add allocator mtl to memory event allowlist. (flutter#151153)
Flutter driver side changes for flutter/engine#53618
1 parent 1c89660 commit 34c590f

File tree

2 files changed

+22
-1
lines changed

2 files changed

+22
-1
lines changed

packages/flutter_driver/lib/src/driver/memory_summarizer.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ class GPUMemorySumarizer {
2121
}
2222

2323
/// Whether or not this event is a GPU allocation event.
24-
static const Set<String> kMemoryEvents = <String>{'AllocatorVK'};
24+
static const Set<String> kMemoryEvents = <String>{'AllocatorVK', 'AllocatorMTL'};
2525

2626
final List<double> _memoryMB = <double>[];
2727

packages/flutter_driver/test/src/gpu_memory_summarizer_test.dart

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,14 @@ TimelineEvent newGPUTraceEvent(double ms) => TimelineEvent(<String, dynamic>{
1515
},
1616
});
1717

18+
TimelineEvent newMetalGPUTraceEvent(double ms) => TimelineEvent(<String, dynamic>{
19+
'name': 'AllocatorMTL',
20+
'ph': 'b',
21+
'args': <String, String>{
22+
'MemoryBudgetUsageMB': ms.toString()
23+
},
24+
});
25+
1826
void main() {
1927
test('Can process GPU memory usage times.', () {
2028
final GPUMemorySumarizer summarizer = GPUMemorySumarizer(<TimelineEvent>[
@@ -28,4 +36,17 @@ void main() {
2836
expect(summarizer.computePercentileMemoryUsage(50.0), closeTo(1024, 0.1));
2937
expect(summarizer.computeWorstMemoryUsage(), 2048);
3038
});
39+
40+
test('Can process Metal GPU memory usage times.', () {
41+
final GPUMemorySumarizer summarizer = GPUMemorySumarizer(<TimelineEvent>[
42+
newMetalGPUTraceEvent(1024),
43+
newMetalGPUTraceEvent(1024),
44+
newMetalGPUTraceEvent(512),
45+
newMetalGPUTraceEvent(2048),
46+
]);
47+
48+
expect(summarizer.computeAverageMemoryUsage(), closeTo(1152, 0.1));
49+
expect(summarizer.computePercentileMemoryUsage(50.0), closeTo(1024, 0.1));
50+
expect(summarizer.computeWorstMemoryUsage(), 2048);
51+
});
3152
}

0 commit comments

Comments
 (0)