Skip to content

Commit 1ee82ba

Browse files
committed
complete challenge wesbos#1
1 parent 508e476 commit 1ee82ba

File tree

2 files changed

+9
-76
lines changed

2 files changed

+9
-76
lines changed

01 - JavaScript Drum Kit/index-START.html

Lines changed: 0 additions & 66 deletions
This file was deleted.

01 - JavaScript Drum Kit/index-FINISHED.html renamed to 01 - JavaScript Drum Kit/index.html

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -58,26 +58,25 @@
5858
<audio data-key="76" src="sounds/tink.wav"></audio>
5959

6060
<script>
61-
function removeTransition(e) {
62-
if (e.propertyName !== 'transform') return;
63-
e.target.classList.remove('playing');
64-
}
65-
6661
function playSound(e) {
62+
// console.log(e.keyCode);
6763
const audio = document.querySelector(`audio[data-key="${e.keyCode}"]`);
68-
const key = document.querySelector(`div[data-key="${e.keyCode}"]`);
64+
const key = document.querySelector(`.key[data-key="${e.keyCode}"]`);
6965
if (!audio) return;
70-
71-
key.classList.add('playing');
7266
audio.currentTime = 0;
7367
audio.play();
68+
key.classList.add('playing');
69+
}
70+
71+
function removeTransition(e) {
72+
if (e.propertyName !== 'transform') return;
73+
this.classList.remove('playing');
7474
}
7575

76-
const keys = Array.from(document.querySelectorAll('.key'));
76+
const keys = document.querySelectorAll('.key');
7777
keys.forEach(key => key.addEventListener('transitionend', removeTransition));
7878
window.addEventListener('keydown', playSound);
7979
</script>
8080

81-
8281
</body>
8382
</html>

0 commit comments

Comments
 (0)