Repository navigation
DATA-3443: Add export_tabular_data to data client - #800
Conversation
| request = ExportTabularDataRequest( | ||
| part_id=part_id, resource_name=resource_name, resource_subtype=resource_subtype, method_name=method_name, interval=interval | ||
| ) | ||
| return await self._data_client.ExportTabularData(request, metadata=self._metadata) |
There was a problem hiding this comment.
ExportTabularDataResponse has a lot of data in it that is maybe not needed? Which fields on the response would the user actually care about? Is it only the payload? Or also tags?
payload is a proto.Struct, which has really bad UI. We should avoid using that where we can, so we should determine what's actually important to return
There was a problem hiding this comment.
There's a note in the scope to optionally only return the payload in the future. As for the comment regarding proto.Struct, probably best for us to talk in person, so I'll wander over to your area again at some point!
Naveed Jooma (njooma)
left a comment
Naveed Jooma (njooma)
left a comment
There was a problem hiding this comment.
This is great, thanks!
| tags: List[str] | ||
| """A list of tags associated with the data point""" | ||
|
|
||
| payload: Mapping[str, Any] |
There was a problem hiding this comment.
Because this payload is coming from a proto.Struct, you might want to make this Mapping[str, ValueTypes] (from viam.utils import ValueTypes)
Vijay Vuyyuru (vijayvuyyuru)
left a comment
Vijay Vuyyuru (vijayvuyyuru)
left a comment
There was a problem hiding this comment.
These changes look good to me, but will defer to anything the SDK team says on this. Thanks Katie!
4 participants
This PR adds the new Data endpoint ExportTabularData to the python SDK.