Skip to content

Add default validator to easy resource #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2024
Merged

Add default validator to easy resource #764

merged 1 commit into from
Oct 11, 2024

Conversation

njooma
Copy link
Member

@njooma njooma commented Oct 11, 2024

This allows for users who have a validate_config function to continue to use EasyResource, and doesn't affect it otherwise.

Useful for the module generator where we default to EasyResource

@njooma njooma requested a review from abe-winter October 11, 2024 16:12
@njooma njooma requested a review from a team as a code owner October 11, 2024 16:12
@njooma njooma requested review from stuqdog and lia-viam October 11, 2024 16:12
@njooma njooma merged commit 69b06c4 into viamrobotics:main Oct 11, 2024
12 checks passed
@njooma njooma deleted the easy-resource-validator branch October 11, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abe-winter abe-winter abe-winter approved these changes

@stuqdog stuqdog Awaiting requested review from stuqdog stuqdog is a code owner automatically assigned from viamrobotics/sdk-netcode

@lia-viam lia-viam Awaiting requested review from lia-viam lia-viam is a code owner automatically assigned from viamrobotics/sdk-netcode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@njooma @abe-winter