RSDK-8303-3: use api version in makefile #696
Conversation
purplenicole730
requested review from
stuqdog,
lia-viam and
njooma
and removed request for
lia-viam
| @@ -23,7 +23,8 @@ typecheck: | |||
| _buf: clean | |||
| rm -rf src/viam/gen | |||
| chmod +x plugin/main.py | |||
| buf generate buf.build/viamrobotics/api | |||
| $(eval API_VERSION := $(shell grep 'API_VERSION' src/viam/version_metadata.py | awk -F '"' '{print $$2}')) | |||
There was a problem hiding this comment.
I think there's one too many $ in here? The command as written fails for me locally, but changing to print $2 works.
There was a problem hiding this comment.
Oh that's interesting. It ran well for me. I just tried making that change and running it. It fails when I only have 1 $.
There was a problem hiding this comment.
From what I understand, we need two $ since only using one means make thinks that it's a makefile variable. make should be passing $$2 as $2 to awk. If this is true, I wonder why it's not working for you, and how it works with only one $. Could it be a difference in versions?
When I use only one $, it becomes: api:vAPI_VERSION = "0.1.327" instead of api:v0.1.327
There was a problem hiding this comment.
Interesting... Well I've been running just on the command line, if it works for you from the makefile then it's probably fine, thanks for following up :)
There was a problem hiding this comment.
Oh, I've been testing by running make buf on the command line.
If you copy/paste grep 'API_VERSION' src/viam/version_metadata.py | awk -F '"' '{print $$2}' into the terminal, then it will fail. For that, if that's what you did, you do need only 1.
Ensures that when a user runs
make bufthat they're generating the right API version.