Skip to content

RSDK-7192 - Provisioning wrappers #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 11, 2024
Merged

RSDK-7192 - Provisioning wrappers #577

merged 6 commits into from
Apr 11, 2024

Conversation

stuqdog
Copy link
Member

@stuqdog stuqdog commented Apr 4, 2024

No description provided.

@stuqdog stuqdog marked this pull request as ready for review April 4, 2024 18:33
@stuqdog stuqdog requested a review from a team as a code owner April 4, 2024 18:33
purplenicole730
purplenicole730 approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@purplenicole730 purplenicole730 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if provisioning should be under app since the proto is in its own folder, but LGTM!

njooma
njooma requested changes Apr 9, 2024
View reviewed changes
src/viam/app/provisioning_client.py
# Make a ViamClient
viam_client = await connect()
# Instantiate a ProvisioningClient to run provisioning client API methods on
provisioning_client = viam_client.provisioning_client
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you have to actually add the provisioning_client as a property on viam_client for this to work?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 yep you're totally right! Thanks for catching that.

@stuqdog
Copy link
Member Author

stuqdog commented Apr 10, 2024

I'm not sure if provisioning should be under app since the proto is in its own folder, but LGTM!

Yeah that's a good question! My thinking was, viam_client is our entrypoint for non-robot based APIs, so it makes sense for provisioning_client to still exist on it. It does mean app becomes a bit of a misnomer in terms of parity with the app repo, but given the general use of these APIs and that this was listed as a cloud API along with data, billing, etc., it seemed to me best to put it here. Happy to see pushback if anyone disagrees!

@stuqdog stuqdog requested a review from njooma April 10, 2024 12:30
@stuqdog stuqdog merged commit 1e31db8 into viamrobotics:main Apr 11, 2024
12 checks passed
@stuqdog stuqdog deleted the provisioning-wrappers branch April 11, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njooma njooma njooma approved these changes

@purplenicole730 purplenicole730 purplenicole730 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stuqdog @njooma @purplenicole730