RSDK-12361 - remove location secret code (#443)

* remove location secret code

* make format

Author: stuqdog

example/viam_robot_example_app/README.md

@@ -16,14 +16,7 @@ API_KEY_ID=<API KEY ID>
 API_KEY=<API KEY>
 ```
 
-or using location secrets (deprecated, please prefer using API keys!):
-
-```
-ROBOT_LOCATION=<ROBOT_LOCATION_URI>
-LOCATION_SECRET=<ROBOT_LOCATION_SECRET>
-```
-
-Both these fields can be obtained from your robot's `Code Sample` tab on [app.viam.com](https://app.viam.com).
+These fields can be obtained from your robot's `Code Sample` tab on [app.viam.com](https://app.viam.com).
 
 ## Run
 

lib/src/robot/client.dart

@@ -49,9 +49,8 @@ class RobotClientOptions {
           ..credentials = Credentials.apiKey(apiKey)
           ..authEntity = apiKeyID;
 
-  /// Convenience initializer for creating options with a robot location secret
-  RobotClientOptions.withLocationSecret(String locationSecret)
-      : dialOptions = DialOptions()..credentials = Credentials.locationSecret(locationSecret);
+  /// Convenience initializer for creating options with a robot secret
+  RobotClientOptions.withRobotSecret(String robotSecret) : dialOptions = DialOptions()..credentials = Credentials.robotSecret(robotSecret);
 }
 
 /// {@category Viam SDK}

lib/src/rpc/dial.dart

@@ -78,16 +78,16 @@ class DialOptions {
 /// {@category Viam SDK}
 /// The credentials used for connecting to the robot
 class Credentials {
-  /// The type of credential, e.g. 'robot-location-secret', 'api-key'
+  /// The type of credential, e.g. 'robot-secret', 'api-key'
   final String type;
 
   /// The payload of the credential
   final String payload;
 
   const Credentials(this.type, this.payload);
 
-  /// Convenience initializer for creating credentials of type 'robot-location-secret' with the provided payload.
-  const Credentials.locationSecret(this.payload) : type = 'robot-location-secret';
+  /// Convenience initializer for creating credentials of type 'robot-secret' with the provided payload.
+  const Credentials.robotSecret(this.payload) : type = 'robot-secret';
 
   /// Convenience initializer for creating credentials of type 'api-key' with the provided key as payload.
   const Credentials.apiKey(this.payload) : type = 'api-key';

lib/src/viam_sdk_impl.dart

@@ -97,10 +97,8 @@ class ViamImpl implements Viam {
 
   @override
   Future<RobotClient> getRobotClient(Robot robot) async {
-    final location = await appClient.getLocation(robot.location);
-    final secret = location.auth.secrets.firstWhere((element) => element.state == SharedSecret_State.STATE_ENABLED);
     final parts = await appClient.listRobotParts(robot.id);
     final part = parts.firstWhere((element) => element.mainPart);
-    return RobotClient.atAddress(part.fqdn, RobotClientOptions.withLocationSecret(secret.secret));
+    return RobotClient.atAddress(part.fqdn, RobotClientOptions.withRobotSecret(part.secret));
   }
 }