Rsdk-13490#6038
Draft
allisonschiang wants to merge 6 commits into
Draft
Conversation
Before merging to main: 1. stable.yml: remove all if: false lines from the deploy jobs (7 of them). 2. stable.yml: change release_type: 'pr' back to 'stable' on the cli and cli-windows-installer jobs. 3. stable.yml: change cli.yml@RSDK-13490 and cli-windows-installer.yml@RSDK-13490 back to @main. 4. stable.yml: restore slack-workflow-status to if: ${{ !success() }}. The if: github.repository == 'viamrobotics/rdk' gates in cli-windows-installer.yml are keepable; don't revert those. How to fire the test without creating a release From your terminal, with your branch checked out: # Push the branch to upstream first (if not already there) git push upstream RSDK-13490 # Create the tag locally git tag v999.999.999 # Push only the tag — no release page is created git push upstream v999.999.999 That fires stable.yml against the commit the tag points at. Go to https://github.com/viamrobotics/rdk/actions to watch it. After testing — clean up the tag # Delete locally git tag -d v999.999.999 # Delete on upstream git push --delete upstream v999.999.999 If you want to re-test before deleting, you can pick a new fake version each time (v999.999.998, v999.999.997, ...) — that's the simplest. Tags are cheap; the cleanup is just multiple git push --delete upstream <tag> calls at the end. What will run on the tag push - ✅ test — runs (slow, but harmless) - ⏭ appimage-build, appimage-deploy, staticbuild-build, staticbuild-deploy, full-static-build, full-static-deploy, droid — skipped (if: false) - ✅ cli — runs in pr mode, builds all platform binaries, uploads windows binary as workflow artifact, no GCS upload - ✅ cli-windows-installer — runs in pr mode, downloads windows artifact, signs viam.exe (since we're on viamrobotics/rdk), runs Inno Setup, signs installer, uploads installer as workflow artifact, no GCS upload - ⏭ slack-workflow-status — skipped (if: false), no Slack noise After it finishes, scroll to the bottom of the run page → Artifacts → download viam-cli-windows-installer (~30 MB zip), unzip, install. Done.
viambot
added
the
safe to test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.