RSDK-11731 — Remove GetImage, Format, and RenderFrame from camera.proto#758
Open
hexbabe wants to merge 4 commits intoviamrobotics:mainfrom
Open
RSDK-11731 — Remove GetImage, Format, and RenderFrame from camera.proto#758hexbabe wants to merge 4 commits intoviamrobotics:mainfrom
hexbabe wants to merge 4 commits intoviamrobotics:mainfrom
Conversation
hexbabe
added
the
allow breaking
oliviamiller
approved these changes
Oct 9, 2025
SebastianMunozP
approved these changes
Oct 16, 2025
seanavery
approved these changes
Nov 3, 2025
seanavery
approved these changes
Nov 3, 2025
|
|
||
| import "common/v1/common.proto"; | ||
| import "google/api/annotations.proto"; | ||
| import "google/api/httpbody.proto"; |
Member
There was a problem hiding this comment.
We still have http hooks right? Is this being pulled in from common?
Member
Author
There was a problem hiding this comment.
think this is just an unused import since we no longer use HttpBody
hexbabe
added
safe to test
hexbabe
removed
the
ready-for-protos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://viam.atlassian.net/browse/RSDK-11731
Hit merge only as the LAST step of removing GetImage. Make sure literally everything else is updated.