[RSDK-10140] add relative bounding box coordinates to detections #640
Conversation
|
For those playing along at home, the scope doc is in RSDK-10082. |
bhaney
left a comment
bhaney
left a comment
There was a problem hiding this comment.
I think the comment should reflect that it its proportion to the respective length or height. It doesnt have to be exactly what i wrote- but its not the total size of the image
| double confidence = 5; | ||
| // label associated with the detected object | ||
| string class_name = 6; | ||
| // the four corners of the box, divided by the size of the entire image |
There was a problem hiding this comment.
Not divided by the size of the entire image, but by their respective dimension. So x norm is the x divided by the x length, and y norm is y divided by the y length. So let's say "the four corners of the box, in proportion to the respective dimension of the image"
There was a problem hiding this comment.
Good point, updated.
I also forgot to run make all to change the Go and JavaScript versions of the code! 😳 I've done that now. This is still the only file I've edited: the rest is just auto-generated.
penguinland
added
the
ready-for-protos
penguinland
removed
the
ready-for-protos
2 participants
Github thinks I should tag Naveed. I'm tagging Bijan, but could be wrong.
I changed the comment from what was in Jira. I'm willing to change it back if you want, though personally I think this is more useful (making the comment say they're normalized doesn't add anything I didn't already get from the field names).