[RSDK-10140] add relative bounding box coordinates to detections #640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For those playing along at home, the scope doc is in RSDK-10082. |
bhaney
requested changes
Mar 7, 2025
| @@ -97,6 +97,11 @@ message Detection { | |||
| double confidence = 5; | |||
| // label associated with the detected object | |||
| string class_name = 6; | |||
| // the four corners of the box, divided by the size of the entire image | |||
There was a problem hiding this comment.
Not divided by the size of the entire image, but by their respective dimension. So x norm is the x divided by the x length, and y norm is y divided by the y length. So let's say "the four corners of the box, in proportion to the respective dimension of the image"
There was a problem hiding this comment.
Good point, updated.
I also forgot to run make all to change the Go and JavaScript versions of the code! 😳 I've done that now. This is still the only file I've edited: the rest is just auto-generated.
penguinland
added
the
ready-for-protos
penguinland
removed
the
ready-for-protos
This was referenced Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github thinks I should tag Naveed. I'm tagging Bijan, but could be wrong.
I changed the comment from what was in Jira. I'm willing to change it back if you want, though personally I think this is more useful (making the comment say they're normalized doesn't add anything I didn't already get from the field names).