Skip to content

Commit ddd3094

Browse files
RSDK-10559 Add optional_dependencies field to ValidateConfigResponse (#685)
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
1 parent 29c7a2e commit ddd3094

File tree

5 files changed

+111
-44
lines changed

5 files changed

+111
-44
lines changed

gen/js/module/v1/module_pb.d.ts

+6
Original file line numberDiff line numberDiff line change
@@ -261,6 +261,11 @@ export class ValidateConfigResponse extends jspb.Message {
261261
setDependenciesList(value: Array<string>): void;
262262
addDependencies(value: string, index?: number): string;
263263

264+
clearOptionalDependenciesList(): void;
265+
getOptionalDependenciesList(): Array<string>;
266+
setOptionalDependenciesList(value: Array<string>): void;
267+
addOptionalDependencies(value: string, index?: number): string;
268+
264269
serializeBinary(): Uint8Array;
265270
toObject(includeInstance?: boolean): ValidateConfigResponse.AsObject;
266271
static toObject(includeInstance: boolean, msg: ValidateConfigResponse): ValidateConfigResponse.AsObject;
@@ -274,6 +279,7 @@ export class ValidateConfigResponse extends jspb.Message {
274279
export namespace ValidateConfigResponse {
275280
export type AsObject = {
276281
dependenciesList: Array<string>,
282+
optionalDependenciesList: Array<string>,
277283
}
278284
}
279285

gen/js/module/v1/module_pb.js

+51-2
Original file line numberDiff line numberDiff line change
@@ -2025,7 +2025,7 @@ proto.viam.module.v1.ValidateConfigRequest.prototype.hasConfig = function() {
20252025
* @private {!Array<number>}
20262026
* @const
20272027
*/
2028-
proto.viam.module.v1.ValidateConfigResponse.repeatedFields_ = [1];
2028+
proto.viam.module.v1.ValidateConfigResponse.repeatedFields_ = [1,2];
20292029

20302030

20312031

@@ -2058,7 +2058,8 @@ proto.viam.module.v1.ValidateConfigResponse.prototype.toObject = function(opt_in
20582058
*/
20592059
proto.viam.module.v1.ValidateConfigResponse.toObject = function(includeInstance, msg) {
20602060
var f, obj = {
2061-
dependenciesList: (f = jspb.Message.getRepeatedField(msg, 1)) == null ? undefined : f
2061+
dependenciesList: (f = jspb.Message.getRepeatedField(msg, 1)) == null ? undefined : f,
2062+
optionalDependenciesList: (f = jspb.Message.getRepeatedField(msg, 2)) == null ? undefined : f
20622063
};
20632064

20642065
if (includeInstance) {
@@ -2099,6 +2100,10 @@ proto.viam.module.v1.ValidateConfigResponse.deserializeBinaryFromReader = functi
20992100
var value = /** @type {string} */ (reader.readString());
21002101
msg.addDependencies(value);
21012102
break;
2103+
case 2:
2104+
var value = /** @type {string} */ (reader.readString());
2105+
msg.addOptionalDependencies(value);
2106+
break;
21022107
default:
21032108
reader.skipField();
21042109
break;
@@ -2135,6 +2140,13 @@ proto.viam.module.v1.ValidateConfigResponse.serializeBinaryToWriter = function(m
21352140
f
21362141
);
21372142
}
2143+
f = message.getOptionalDependenciesList();
2144+
if (f.length > 0) {
2145+
writer.writeRepeatedString(
2146+
2,
2147+
f
2148+
);
2149+
}
21382150
};
21392151

21402152

@@ -2175,4 +2187,41 @@ proto.viam.module.v1.ValidateConfigResponse.prototype.clearDependenciesList = fu
21752187
};
21762188

21772189

2190+
/**
2191+
* repeated string optional_dependencies = 2;
2192+
* @return {!Array<string>}
2193+
*/
2194+
proto.viam.module.v1.ValidateConfigResponse.prototype.getOptionalDependenciesList = function() {
2195+
return /** @type {!Array<string>} */ (jspb.Message.getRepeatedField(this, 2));
2196+
};
2197+
2198+
2199+
/**
2200+
* @param {!Array<string>} value
2201+
* @return {!proto.viam.module.v1.ValidateConfigResponse} returns this
2202+
*/
2203+
proto.viam.module.v1.ValidateConfigResponse.prototype.setOptionalDependenciesList = function(value) {
2204+
return jspb.Message.setField(this, 2, value || []);
2205+
};
2206+
2207+
2208+
/**
2209+
* @param {string} value
2210+
* @param {number=} opt_index
2211+
* @return {!proto.viam.module.v1.ValidateConfigResponse} returns this
2212+
*/
2213+
proto.viam.module.v1.ValidateConfigResponse.prototype.addOptionalDependencies = function(value, opt_index) {
2214+
return jspb.Message.addToRepeatedField(this, 2, value, opt_index);
2215+
};
2216+
2217+
2218+
/**
2219+
* Clears the list making it empty but non-null.
2220+
* @return {!proto.viam.module.v1.ValidateConfigResponse} returns this
2221+
*/
2222+
proto.viam.module.v1.ValidateConfigResponse.prototype.clearOptionalDependenciesList = function() {
2223+
return this.setOptionalDependenciesList([]);
2224+
};
2225+
2226+
21782227
goog.object.extend(exports, proto.viam.module.v1);

module/v1/module.pb.go

+47-36
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

module/v1/module_grpc.pb.go

+4-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

proto/viam/module/v1/module.proto

+3-2
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ service ModuleService {
2121
// Ready determines if the server is started and ready to recieve resource configurations.
2222
rpc Ready(ReadyRequest) returns (ReadyResponse);
2323

24-
// ValidateConfig determines whether the given config is valid and registers/returns implicit
25-
// dependencies.
24+
// ValidateConfig determines whether the given config is valid and registers/returns
25+
// both required and optional implicit dependencies.
2626
rpc ValidateConfig(ValidateConfigRequest) returns (ValidateConfigResponse);
2727
}
2828

@@ -68,4 +68,5 @@ message ValidateConfigRequest {
6868

6969
message ValidateConfigResponse {
7070
repeated string dependencies = 1;
71+
repeated string optional_dependencies = 2;
7172
}

0 commit comments

Comments
 (0)