Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underglow Brightness and the Value of Underglow Color. #275

Open
chronocide-commando opened this issue Nov 2, 2022 · 3 comments
Open

Underglow Brightness and the Value of Underglow Color. #275

chronocide-commando opened this issue Nov 2, 2022 · 3 comments

Comments

@chronocide-commando
Copy link

Setting the Value (as in HSV) of Underglow Color currently sets the Underglow Brightness for the entire keyboard (and vice versa).

This behavior prevents the user from setting different brightness/Value for individual LEDs using Lighting Layers, instead forcing the same value for the entire keyboard.

Suggestion: Underglow Brightness should work as an additional multiplier applied to LED brightness/Value instead of setting it directly. This way it would control the overall brightness while preserving the relative difference between LEDs.

@TweetyDaBird
Copy link
Contributor

This is in-fact the desired and expected behavior. Underglow per definition is intended to affect all of the RGBs.

To use the RGB diodes individually you should assign them as an RGB matrix first and use those functions. That gives you a lot more granular control.

@chronocide-commando
Copy link
Author

RGB Matrix is for keyboards with external drivers, if I understand correctly (which my keyboard doesn't have), but both RGB Light and RGB Matrix allow for individual LED control. RGB Light has Lighting Layers and RGB Matrix has Indicators, but they do the same thing and are apparently intended for the same purpose.

For the LEDs individually controlled through Lighting Layers it would make more sense for the Underglow Brightness setting to affect them like a Brightness setting on TVs, by proportionately changing the brightness of every pixel rather than setting them all to have the same brightness.

Right now the Val of Lighting Layers is either directly set to exactly the same number as Underglow Brightness (while Hue and Sat retain their values set by user) or completely unaffected by it, depending on RGBLIGHT_LAYERS_RETAIN_VAL.

@TweetyDaBird
Copy link
Contributor

RGB Matrix does not in any way require external drivers. It works fine with addressable RGB's as long as you define them as a matrix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants