add exceptions parameter to client_object.execute_query_retry to mirror client_runtime_context.execute_query_retry #890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or client_runtime_context.execute_query_retry
|
I just saw ClientResult uses this as well and is also missing the parameter. I will add that when I get home. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
client_runtime_context.execute_query_retrytakes anexceptionsparameter that controls what exceptions would be retried.client_object.execute_query_retrydoes not have that parameter, despite simply wrappingclient_runtime_context.execute_query_retry.As far as I can tell, this was simply an oversight when the parameter was added to the method in client_runtime_context, and I see no reason why client_object should not also have that parameter.