Skip to content

Commit 53c9659

Browse files
authored
Merge branch 'master' into rewrite-engine-terminate-and-co
2 parents 5365d42 + d0d8664 commit 53c9659

File tree

3 files changed

+6
-9
lines changed

3 files changed

+6
-9
lines changed

examples/contrib/cifar10/main.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ def initialize(config):
260260

261261
def log_metrics(logger, epoch, elapsed, tag, metrics):
262262
metrics_output = "\n".join([f"\t{k}: {v}" for k, v in metrics.items()])
263-
logger.info(f"\nEpoch {epoch} - Evaluation time (seconds): {elapsed:.2f} - {tag} metrics:\n {metrics_output}")
263+
logger.info(f"Epoch[{epoch}] - Evaluation time (seconds): {elapsed:.3f}\n - {tag} metrics:\n {metrics_output}")
264264

265265

266266
def log_basic_info(logger, config):
@@ -380,9 +380,6 @@ def evaluate_step(engine: Engine, batch):
380380
for name, metric in metrics.items():
381381
metric.attach(evaluator, name)
382382

383-
if idist.get_rank() == 0 and (not config["with_clearml"]):
384-
common.ProgressBar(desc=f"Evaluation ({tag})", persist=False).attach(evaluator)
385-
386383
return evaluator
387384

388385

ignite/engine/engine.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -776,7 +776,7 @@ def _internal_run(self) -> State:
776776

777777
hours, mins, secs = _to_hours_mins_secs(epoch_time_taken)
778778
self.logger.info(
779-
f"Epoch[{self.state.epoch}] Complete. Time taken: {hours:02d}:{mins:02d}:{secs:02d}"
779+
f"Epoch[{self.state.epoch}] Complete. Time taken: {hours:02d}:{mins:02d}:{secs:06.3f}"
780780
)
781781

782782
except _EngineTerminateException:
@@ -791,7 +791,7 @@ def _internal_run(self) -> State:
791791
# update time wrt handlers
792792
self.state.times[Events.COMPLETED.name] = time_taken
793793
hours, mins, secs = _to_hours_mins_secs(time_taken)
794-
self.logger.info(f"Engine run complete. Time taken: {hours:02d}:{mins:02d}:{secs:02d}")
794+
self.logger.info(f"Engine run complete. Time taken: {hours:02d}:{mins:02d}:{secs:06.3f}")
795795

796796
except BaseException as e:
797797
self._dataloader_iter = None

ignite/engine/utils.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ def _check_signature(fn: Callable, fn_description: str, *args: Any, **kwargs: An
2121
)
2222

2323

24-
def _to_hours_mins_secs(time_taken: Union[float, int]) -> Tuple[int, int, int]:
25-
"""Convert seconds to hours, mins, and seconds."""
24+
def _to_hours_mins_secs(time_taken: Union[float, int]) -> Tuple[int, int, float]:
25+
"""Convert seconds to hours, mins, seconds and milliseconds."""
2626
mins, secs = divmod(time_taken, 60)
2727
hours, mins = divmod(mins, 60)
28-
return round(hours), round(mins), round(secs)
28+
return round(hours), round(mins), secs

0 commit comments

Comments
 (0)