Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete unused keyword step #5117

Merged
merged 3 commits into from
Dec 28, 2022
Merged

delete unused keyword step #5117

merged 3 commits into from
Dec 28, 2022

Conversation

nevermore3
Copy link
Contributor

@nevermore3 nevermore3 commented Dec 26, 2022 •
edited
Loading

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

close https://github.com/vesoft-inc/nebula-ent/issues/1796

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

Aiee
Aiee previously approved these changes Dec 27, 2022
View reviewed changes
@codesigner codesigner added the ready-for-testing PR: ready for the CI test label Dec 27, 2022
@nevermore3
Copy link
Contributor Author

@abby-cyber please remove keyword 'step' from documentation

@nevermore3 nevermore3 requested review from Aiee and xtcyclist December 27, 2022 08:02
@Sophie-Xie Sophie-Xie added the doc affected PR: improvements or additions to documentation label Dec 27, 2022
xtcyclist
xtcyclist previously approved these changes Dec 28, 2022
View reviewed changes
@Sophie-Xie Sophie-Xie requested a review from jievince December 28, 2022 03:55
@Sophie-Xie Sophie-Xie merged commit b85ae3c into vesoft-inc:master Dec 28, 2022
@nevermore3 nevermore3 deleted the del_keyword_step branch December 28, 2022 09:35
nevermore3 added a commit that referenced this pull request Dec 30, 2022
@nevermore3
Revert "delete unused keyword step (#5117)"
48dbaec 
This reverts commit b85ae3c.
@nevermore3 nevermore3 mentioned this pull request Dec 30, 2022
Merged
Sophie-Xie pushed a commit that referenced this pull request Dec 30, 2022
@nevermore3
Revert "delete unused keyword step (#5117)" (#5164)
712884e 
This reverts commit b85ae3c.
@wey-gu wey-gu mentioned this pull request Dec 31, 2022
Closed
@abby-cyber
Copy link
Contributor

After discussion, add step in the doc. vesoft-inc/nebula-docs-cn#2429

yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Jan 31, 2023
@nebula-bots @nevermore3
Revert "delete unused keyword step (vesoft-inc#5117)" (vesoft-inc#2070)
e9e6e57 
This reverts commit b85ae3c.

Co-authored-by: jimingquan <mingquan.ji@vesoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xtcyclist xtcyclist xtcyclist approved these changes

@jievince jievince jievince approved these changes

@Aiee Aiee Awaiting requested review from Aiee

Assignees

@abby-cyber abby-cyber

Labels
doc affected PR: improvements or additions to documentation ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nevermore3 @abby-cyber @xtcyclist @Aiee @jievince @codesigner @Sophie-Xie