Support get spaceId from meta server with FileBasedSchemaManager #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is another problem about module dependency. Let's refactor it in another issue. |
|
Unit testing passed. |
Merged
|
Unit testing passed. |
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Feb 16, 2020
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Mar 21, 2022
Co-authored-by: jakevin <30525741+jackwener@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we support create space on meta server, which means the spaceID is generated on the server-side. But we still use FileBasedSchemaManager and the spaceID is calculated locally. To fix the conflicts about SpaceID, we give another flag "graph_id_from_server". Therefore, we could get spaceId from meta server while using FileBaseSchemaManager