Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix not init argv #2298

Merged
merged 1 commit into from
Aug 13, 2020
Merged

Fix not init argv #2298

merged 1 commit into from
Aug 13, 2020

Conversation

laura-ding
Copy link
Contributor

No description provided.

@laura-ding laura-ding added the ready-for-testing PR: ready for the CI test label Aug 13, 2020
@bright-starry-sky
Copy link
Contributor

Do we need to change folly::init(&argc, &argv, true) to folly::init(&argc, &argv, false) ?

@laura-ding
Copy link
Contributor Author

Do we need to change folly::init(&argc, &argv, true) to folly::init(&argc, &argv, false) ?

Don't need, because the code does not use argv anymore.

bright-starry-sky
bright-starry-sky approved these changes Aug 13, 2020
View reviewed changes
Copy link
Contributor

@bright-starry-sky bright-starry-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Well done.

dutor
dutor approved these changes Aug 13, 2020
View reviewed changes
Copy link
Contributor

@dutor dutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right on!

@dutor dutor merged commit 2b22c91 into vesoft-inc:master Aug 13, 2020
xuguruogu pushed a commit to xuguruogu/nebula that referenced this pull request Sep 12, 2020
@laura-ding @xuguruogu
fix argv not init (vesoft-inc#2298)
9f04bef
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
@laura-ding
fix argv not init (vesoft-inc#2298)
b8bcf0e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bright-starry-sky bright-starry-sky bright-starry-sky approved these changes

@dutor dutor dutor approved these changes

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laura-ding @bright-starry-sky @dutor