Skip to content

TCK framework is confusing #3638

Closed
Closed
@zhaohaifei

Description

@zhaohaifei

Introduction
The TCK framework is confusing:

  1. The entire framework is divided into test and tck, but a lot of content in test can be implemented using tck.
  2. Some methods are not abstract enough, such as NebulaService.start(), in which not only starts the nebula service, but also executes "add hosts".
  3. Many global variables are distributed in various files, with different names, but the content is the same. For example, CURR_PATH in nebula-test-run.py, CURR_DIR and TEST_DIR in makefile.
  4. Some variables are confusing, such as NB_TMP_PATH and SPACE_TMP_PATH, which seems directory names, but are actually file names.

In short, TCK is not good enough. It's better to make some changes.

Contents

Related work

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    type/enhancementType: make the code neat or more efficient

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions