Skip to content

Merge GetProps and ScanVertices/ScanEdges RPC. #3450

Closed
@Shylock-Hg

Description

@Shylock-Hg

Introduction

Merge GetProps and ScanVertices/ScanEdges into one RPC. Because they should behaviors same except ScanVertices and ScanEdges get vertex/edge id by scan storage but GetProps get vertex/edge id from input.

  1. So there are much same code in their implementation, combine to one will reduce these.
  2. Combine to one will guarantee behavioring same more. And easier to maintain.

Contents

The combined RPC named GeProps, with given vertex/edge id it behaviors as origin GetProps, without it behaviors as ScanVertices and ScanEdges.

But maybe lead to more complex to plan analysis. Or we don't merge the related plan node/executor.

Related work

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    type/enhancementType: make the code neat or more efficient

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions