Delete some fatal and CHECK (#5439)

Author: czpmango

src/graph/visitor/DeduceTypeVisitor.cpp

@@ -219,7 +219,6 @@ void DeduceTypeVisitor::visit(UnaryExpression *expr) {
       break;
     }
     default: {
-      DLOG(FATAL) << "Invalid unary expression kind: " << static_cast<uint8_t>(expr->kind());
       std::stringstream ss;
       ss << "`" << expr->toString() << "' is invalid unary expression, kind is "
          << static_cast<uint8_t>(expr->kind()) << ".";
@@ -284,7 +283,6 @@ void DeduceTypeVisitor::visit(ArithmeticExpression *expr) {
       break;
     }
     default: {
-      DLOG(FATAL) << "Invalid arithmetic expression kind: " << static_cast<uint8_t>(expr->kind());
       std::stringstream ss;
       ss << "`" << expr->toString() << "' is invalid arithmetic expression, kind is "
          << static_cast<uint8_t>(expr->kind()) << ".";
@@ -430,7 +428,6 @@ void DeduceTypeVisitor::visit(LogicalExpression *expr) {
       break;
     }
     default: {
-      DLOG(FATAL) << "Invalid logical expression kind: " << static_cast<uint8_t>(expr->kind());
       std::stringstream ss;
       ss << "`" << expr->toString() << "' is invalid logical expression, kind is "
          << static_cast<uint8_t>(expr->kind()) << ".";

src/graph/visitor/ExtractPropExprVisitor.cpp

@@ -91,7 +91,6 @@ void ExtractPropExprVisitor::visit(UnaryExpression* expr) {
       break;
     }
     default: {
-      DLOG(FATAL) << "Invalid Kind " << expr->kind();
       reportError(expr);
     }
   }
@@ -109,7 +108,6 @@ void ExtractPropExprVisitor::visitPropertyExpr(PropertyExpression* expr) {
       break;
     }
     default: {
-      DLOG(FATAL) << "Invalid Kind " << expr->kind();
       reportError(expr);
       return;
     }
@@ -163,7 +161,6 @@ void ExtractPropExprVisitor::visitVertexEdgePropExpr(PropertyExpression* expr) {
       break;
     }
     default: {
-      DLOG(FATAL) << "Invalid Kind " << expr->kind();
       reportError(expr);
       return;
     }

src/graph/visitor/PrunePropertiesVisitor.cpp

@@ -215,6 +215,8 @@ void PrunePropertiesVisitor::visit(Traverse *node) {
 
 void PrunePropertiesVisitor::visitCurrent(Traverse *node) {
   auto &colNames = node->colNames();
+  // The number of output columns of the Traverse operator is at least two(starting point and edge),
+  // which is by design.
   DCHECK_GE(colNames.size(), 2);
   auto &nodeAlias = colNames[colNames.size() - 2];
   auto &edgeAlias = colNames.back();
@@ -237,6 +239,8 @@ void PrunePropertiesVisitor::visitCurrent(Traverse *node) {
 
 void PrunePropertiesVisitor::pruneCurrent(Traverse *node) {
   auto &colNames = node->colNames();
+  // The number of output columns of the Traverse operator is at least two(starting point and edge),
+  // which is by design.
   DCHECK_GE(colNames.size(), 2);
   auto &nodeAlias = colNames[colNames.size() - 2];
   auto &edgeAlias = colNames.back();
@@ -447,11 +451,11 @@ void PrunePropertiesVisitor::visit(HashJoin *node) {
 }
 
 void PrunePropertiesVisitor::visit(CrossJoin *node) {
-  status_ = pruneMultiBranch(node->dependencies());
+  status_ = pruneBinaryBranch(node->dependencies());
 }
 
 void PrunePropertiesVisitor::visit(Union *node) {
-  status_ = pruneMultiBranch(node->dependencies());
+  status_ = pruneBinaryBranch(node->dependencies());
 }
 
 void PrunePropertiesVisitor::visit(Unwind *node) {
@@ -473,7 +477,7 @@ void PrunePropertiesVisitor::visitCurrent(Unwind *node) {
   }
 }
 
-Status PrunePropertiesVisitor::pruneMultiBranch(std::vector<const PlanNode *> &dependencies) {
+Status PrunePropertiesVisitor::pruneBinaryBranch(std::vector<const PlanNode *> &dependencies) {
   DCHECK_EQ(dependencies.size(), 2);
   auto rightPropsUsed = propsUsed_;
   auto *leftDep = dependencies.front();

src/graph/visitor/PrunePropertiesVisitor.h

@@ -76,7 +76,7 @@ class PrunePropertiesVisitor final : public PlanNodeVisitor {
 
  private:
   Status depsPruneProperties(std::vector<const PlanNode *> &dependencies);
-  Status pruneMultiBranch(std::vector<const PlanNode *> &dependencies);
+  Status pruneBinaryBranch(std::vector<const PlanNode *> &dependencies);
   Status extractPropsFromExpr(const Expression *expr, const std::string &entityAlias = "");
 
   PropertyTracker &propsUsed_;