Add warning msg for partially performed (#2290)

* add warning for partially performed

* address comment

Co-authored-by: dutor <440396+dutor@users.noreply.github.com>

Author: laura-ding

src/graph/DropSpaceExecutor.cpp

@@ -40,6 +40,8 @@ void DropSpaceExecutor::execute() {
         if (*spaceName_ == ectx()->rctx()->session()->spaceName()) {
             ectx()->rctx()->session()->setSpace("", -1);
         }
+        ectx()->addWarningMsg("Data will be deleted completely after restarting the services");
+
         doFinish(Executor::ProcessControl::kNext);
     };
 
@@ -53,9 +55,5 @@ void DropSpaceExecutor::execute() {
 
     std::move(future).via(runner).thenValue(cb).thenError(error);
 }
-
-void DropSpaceExecutor::setupResponse(cpp2::ExecutionResponse &resp)  {
-    resp.set_warning_msg("Data will be deleted completely after restarting the services.");
-}
 }   // namespace graph
 }   // namespace nebula

src/graph/DropSpaceExecutor.h

@@ -25,8 +25,6 @@ class DropSpaceExecutor final : public Executor {
 
     void execute() override;
 
-    void setupResponse(cpp2::ExecutionResponse &resp) override;
-
 private:
     DropSpaceSentence       *sentence_{nullptr};
     const std::string       *spaceName_{nullptr};

src/graph/ExecutionContext.h

@@ -75,6 +75,14 @@ class ExecutionContext final : public cpp::NonCopyable, public cpp::NonMovable {
         return charsetInfo_;
     }
 
+    void addWarningMsg(std::string msg) {
+        warnMsgs_.emplace_back(std::move(msg));
+    }
+
+    const std::vector<std::string>& getWarningMsg() const {
+        return warnMsgs_;
+    }
+
 private:
     RequestContextPtr                           rctx_;
     meta::SchemaManager                        *sm_{nullptr};
@@ -83,6 +91,7 @@ class ExecutionContext final : public cpp::NonCopyable, public cpp::NonMovable {
     meta::MetaClient                           *metaClient_{nullptr};
     std::unique_ptr<VariableHolder>             variableHolder_;
     CharsetInfo                                *charsetInfo_{nullptr};
+    std::vector<std::string>                    warnMsgs_;
 };
 
 }   // namespace graph

src/graph/ExecutionPlan.cpp

@@ -62,6 +62,10 @@ void ExecutionPlan::onFinish() {
     rctx->resp().set_latency_in_us(latency);
     auto &spaceName = rctx->session()->spaceName();
     rctx->resp().set_space_name(spaceName);
+    if (!ectx()->getWarningMsg().empty()) {
+        rctx->resp().set_warning_msg(
+                folly::stringPrintf("%s.", folly::join(", ", ectx()->getWarningMsg()).c_str()));
+    }
     rctx->finish();
 
     // The `ExecutionPlan' is the root node holding all resources during the execution.

src/graph/FetchEdgesExecutor.cpp

@@ -321,6 +321,7 @@ void FetchEdgesExecutor::fetchEdges() {
                 LOG(ERROR) << "part: " << error.first
                            << "error code: " << static_cast<int>(error.second);
             }
+            ectx()->addWarningMsg("Fetch edges executor was partially performed");
         }
         processResult(std::move(result));
         return;

src/graph/FetchVerticesExecutor.cpp

@@ -341,6 +341,7 @@ void FetchVerticesExecutor::fetchVertices() {
                 LOG(ERROR) << "part: " << error.first
                            << "error code: " << static_cast<int>(error.second);
             }
+            ectx()->addWarningMsg("Fetch vertices executor was partially performed");
         }
         processResult(std::move(result));
    };

src/graph/FindPathExecutor.cpp

@@ -520,6 +520,7 @@ void FindPathExecutor::getToFrontiers(
                 LOG(ERROR) << "part: " << error.first
                            << "error code: " << static_cast<int>(error.second);
             }
+            ectx()->addWarningMsg("Find path executor was partially performed");
         }
         auto status = doFilter(std::move(result), where_.filter_, false, frontiers);
         if (!status.ok()) {

src/graph/GoExecutor.cpp

@@ -554,6 +554,7 @@ void GoExecutor::stepOut() {
                 LOG(ERROR) << "part: " << error.first
                            << "error code: " << static_cast<int>(error.second);
             }
+            warningMsg_ = "Go executor was partially performed";
         }
         if (FLAGS_trace_go) {
             LOG(INFO) << "Step:" << curStep_
@@ -724,7 +725,9 @@ void GoExecutor::finishExecution() {
             yc.emplace_back(std::move(ptr));
         }
     }
-
+    if (!warningMsg_.empty()) {
+        ectx()->addWarningMsg(warningMsg_);
+    }
 
     if (onResult_) {
         std::unique_ptr<InterimResult> outputs;
@@ -947,6 +950,7 @@ void GoExecutor::fetchVertexProps(std::vector<VertexID> ids) {
                 LOG(ERROR) << "part: " << error.first
                            << "error code: " << static_cast<int>(error.second);
             }
+            warningMsg_ = "Go executor was partially performed";
         }
         if (vertexHolder_ == nullptr) {
             vertexHolder_ = std::make_unique<VertexHolder>(ectx);

src/graph/GoExecutor.h

@@ -246,6 +246,7 @@ class GoExecutor final : public TraverseExecutor {
     std::vector<RpcResponse>                    records_;
     // The name of Tag or Edge, index of prop in data
     using SchemaPropIndex = std::unordered_map<std::pair<std::string, std::string>, int64_t>;
+    std::string                                  warningMsg_;
 };
 
 }   // namespace graph

src/graph/LookupExecutor.cpp

@@ -329,6 +329,7 @@ void LookupExecutor::lookUp() {
                 LOG(ERROR) << "part: " << error.first
                            << "error code: " << static_cast<int>(error.second);
             }
+            ectx()->addWarningMsg("Lookup executor was partially performed");
         }
         finishExecution(std::forward<decltype(result)>(result));
     };