Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support delete #273

Closed
veezhang opened this issue Jun 7, 2023 · 6 comments
Closed

support delete #273

veezhang opened this issue Jun 7, 2023 · 6 comments
Assignees
Labels
type/feature req Type: feature request

Comments

@veezhang
Copy link
Contributor

veezhang commented Jun 7, 2023

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

@veezhang veezhang added the type/feature req Type: feature request label Jun 7, 2023
@veezhang veezhang self-assigned this Jun 7, 2023
@wey-gu
Copy link
Contributor

wey-gu commented Jun 7, 2023

delete was supported in last version with the label -, just in case it's not aware of.

cc @HarrisChu

@HarrisChu
Copy link
Contributor

still doubt the user case...

@wey-gu
Copy link
Contributor

wey-gu commented Jun 7, 2023

still doubt the user case...

I actually had been seeing users asking about this(last night there is one, already).

I was thinking that you mentioned there are almost no users using it, but maybe not that few, and some users don't know it's possible as it's not highlighted enough in docs or so?

@veezhang
Copy link
Contributor Author

veezhang commented Jun 8, 2023

The previous method required modifying the file, which is usually relatively large, and it is not suitable to modify it casually.
And now add mode in configuration file to support it now.
The default value is INSERT, optionally INSERT, UPDATE, DELETE.

@veezhang
Copy link
Contributor Author

veezhang commented Jun 8, 2023

still doubt the user case...

This is what a customer delivery project needs, a temporary and urgent implementation.

@wey-gu
Copy link
Contributor

wey-gu commented Jun 8, 2023

This method(without needing modification on csv files)is more general to me,👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature req Type: feature request
Projects
None yet
Development

No branches or pull requests

3 participants