Don't reference Commits.BucketId and .StreamId #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these are constant
|
IIRC @lremedi added (some of) these predicates to induce SQL server into using a supporting index, with a vastly improved query plan |
|
Probably. If that improves performance, just think what https://github.com/versionone/Core/pull/6582 can do! |
lremedi
reviewed
Jan 22, 2024
| where Instance='MetaStreamSubscription' and Type='CatchupSubscriptionManager' | ||
| ), | ||
| ActivityStreamCommits as ( | ||
| select cast(CommitStamp as datetime) CommitStamp, CheckpointNumber, CommitSequence | ||
| from Commits | ||
| where BucketId = 'Meta' and StreamId = '1EE3982777943C1BD64B154C4B5008DC0C3815A0' |
There was a problem hiding this comment.
As Pavel mentioned, this should be tested, because without this filters I've seen poor execution plans on allstate db
There was a problem hiding this comment.
Right, because they are the major columns in all the indexes. https://github.com/versionone/Core/pull/6582/files?diff=split&w=1#diff-3b86a3165f9ad8c314d8cb0a96956aa895e351607767e829b1fc09eb0ef3c419R24-R30 fixes that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these are constant.
This PR anticipates https://github.com/versionone/Core/pull/6582