World postgres minor fixes #306
Conversation
🦋 Changeset detectedLatest commit: e4ffca9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@paulhenri-l is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| "created_at" timestamp DEFAULT now() NOT NULL, | ||
| "updated_at" timestamp DEFAULT now() NOT NULL | ||
| "updated_at" timestamp DEFAULT now() NOT NULL, | ||
| "retry_after" timestamp |
There was a problem hiding this comment.
I have an upcoming pr to move the world to drizzle migrator, it will make future schema changes much easier to maintain
pranaygp
left a comment
pranaygp
left a comment
There was a problem hiding this comment.
Thanks @paulhenri-l
looks like there's a merge conflict that needs fixing before this can be merged. It's also missing a changeset which if you can add would be awesome or I can do it for you too. just run pnpm changeset from the repo root and make sure to use patch
lastly, please just make sure you signoff the commit: https://github.com/vercel/workflow/pull/306/checks?check_run_id=55111524658
Signed-off-by: paulhenri-l <25308170+paulhenri-l@users.noreply.github.com>
Signed-off-by: paulhenri-l <25308170+paulhenri-l@users.noreply.github.com>
paulhenri-l
force-pushed
the
world-postgres-fix
branch
from
596d704 to
e4ffca9
Compare
|
Should be good now |
2 participants
When trying to use the postgres world as explained in the doc the user will face two issues:
Storage params were also completely ignored, they are now taken into account.
This PR aims to fix these two little issues allowing users to try the postgres world while I'll work on a more stable version.