-
Notifications
You must be signed in to change notification settings - Fork 94
Add 'Pass-by-Value Semantics' section to serialization docs #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Nathan Rajlich <n@n8.io>
🦋 Changeset detectedLatest commit: d15a60d The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| } | ||
| ``` | ||
|
|
||
| ## Pass-by-Value Semantics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this section looks super AI generated and verbose. Can you please summarize it/be terse with the examples and drop the emojis?
|
|
||
| By default, steps have a maximum of 3 retry attempts before they fail and propagate the error over to the workflow. Learn more about errors and retrying in the [Errors & Retrying](/docs/foundations/errors-and-retries) page. | ||
|
|
||
| <Callout type="warning"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great!
pranaygp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
too AI generated. let's be more terse and drop the emojis please
|
@pranaygp Ok how about now? |
It's been seen a few times already that incorrect code assumes that mutations to a step's arguments will be visible to the outer workflow context, which is not the case. Since this is a semantic departure from typical JavaScript runtime behavior, it warrants a section in the documentation explaining the correct approach.