Add support for jsconfig.json resolution #3409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There doesn't appear to be any issues with just returning a `jsconfig.json` when we're looking for a `tsconfig.json` (provided one didn't exist). Finding this a `TsConfigReferenceVc` (used for finding type definitions only), and enable the `paths`/`baseUrl` resolution options.
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
Contributor
Benchmark for f0396cfClick to view benchmark
|
Contributor
🟢 CI successful 🟢Thanks |
jridgewell
added
the
pr: automerge
Contributor
Benchmark for b6f668bClick to view benchmark
|
padmaia
approved these changes
Jan 21, 2023
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Jan 21, 2023
### Features - vercel/turborepo#3409 ### Bug Fixes - vercel/turborepo#3399 - vercel/turborepo#3412 ### Chore - vercel/turborepo#3398 - vercel/turborepo#3391 - vercel/turborepo#3350
ijjk
added a commit
to vercel/next.js
that referenced
this pull request
Jan 26, 2023
Enables the JS CNA template tests for turbopack as well now that we landed `jsconfig` paths support. x-ref: vercel/turborepo#3409
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
There doesn't appear to be any issues with just returning a `jsconfig.json` when we're looking for a `tsconfig.json` (provided one didn't exist). Finding this gives a `TsConfigReferenceVc` (used for finding type definitions only) and enables the `paths`/`baseUrl` resolution options. Fixes WEB-230
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
There doesn't appear to be any issues with just returning a `jsconfig.json` when we're looking for a `tsconfig.json` (provided one didn't exist). Finding this gives a `TsConfigReferenceVc` (used for finding type definitions only) and enables the `paths`/`baseUrl` resolution options. Fixes WEB-230
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
There doesn't appear to be any issues with just returning a `jsconfig.json` when we're looking for a `tsconfig.json` (provided one didn't exist). Finding this gives a `TsConfigReferenceVc` (used for finding type definitions only) and enables the `paths`/`baseUrl` resolution options. Fixes WEB-230
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There doesn't appear to be any issues with just returning a
jsconfig.jsonwhen we're looking for atsconfig.json(provided one didn't exist). Finding this gives aTsConfigReferenceVc(used for finding type definitions only) and enables thepaths/baseUrlresolution options.Fixes WEB-230