Got task hashes to match!

Author: nicholaslyang

cli/internal/context/context.go

@@ -169,15 +169,13 @@ func BuildPackageGraph(repoRoot turbopath.AbsoluteSystemPath, rootPackageJSON *f
 		TurboConfigs: map[string]*fs.TurboJSON{},
 	}
 	c.RootNode = core.ROOT_NODE_NAME
-
 	var warnings Warnings
 
 	packageManager, err := packagemanager.GetPackageManager(packageManagerName)
 	if err != nil {
 		return nil, err
 	}
 	c.PackageManager = packageManager
-
 	if err := c.resolveWorkspaceRootDeps(rootPackageJSON, &warnings); err != nil {
 		// TODO(Gaspar) was this the intended return error?
 		return nil, fmt.Errorf("could not resolve workspaces: %w", err)
@@ -186,7 +184,6 @@ func BuildPackageGraph(repoRoot turbopath.AbsoluteSystemPath, rootPackageJSON *f
 	// Get the workspaces from the package manager.
 	// workspaces are absolute paths
 	workspaces, err := c.PackageManager.GetWorkspaces(repoRoot)
-
 	if err != nil {
 		return nil, fmt.Errorf("workspace configuration error: %w", err)
 	}
@@ -212,7 +209,6 @@ func BuildPackageGraph(repoRoot turbopath.AbsoluteSystemPath, rootPackageJSON *f
 			return c.populateWorkspaceGraphForPackageJSON(pkg, rootpath, pkg.Name, &warnings)
 		})
 	}
-
 	if err := populateGraphWaitGroup.Wait(); err != nil {
 		return nil, err
 	}
@@ -224,7 +220,6 @@ func BuildPackageGraph(repoRoot turbopath.AbsoluteSystemPath, rootPackageJSON *f
 		return nil, fmt.Errorf("failed to resolve dependencies for root package: %v", err)
 	}
 	c.WorkspaceInfos.PackageJSONs[util.RootPkgName] = rootPackageJSON
-
 	if err := c.populateExternalDeps(repoRoot, rootPackageJSON, &warnings); err != nil {
 		return nil, err
 	}

cli/internal/fs/hash.go

@@ -32,6 +32,7 @@ func HashFileHashes(hashes FileHashes) (string, error) {
 
 // HashTask produces the hash for a particular task
 func HashTask(task *hash.TaskHashable) (string, error) {
+	fmt.Printf("%+v\n", task)
 	return hash.HashTaskHashable(task)
 }
 

cli/internal/fs/hash/capnp.go

@@ -378,8 +378,6 @@ func HashMessage(msg *capnp.Message) (string, error) {
 		return "", err
 	}
 
-	println(hex.EncodeToString(bytes))
-
 	digest := xxhash.New()
 	_, err = digest.Write(bytes)
 	if err != nil {

cli/internal/run/real_run.go

@@ -286,8 +286,6 @@ func RealRun(
 		expectedTaskHashes := taskHashTracker.GetTaskHashes()
 		if !reflect.DeepEqual(executionState.TaskHashTracker.PackageTaskHashes, expectedTaskHashes) {
 			return fmt.Errorf("task hashes differ between Rust and Go: rust %v go %v", executionState.TaskHashTracker.PackageTaskHashes, expectedTaskHashes)
-		} else {
-			fmt.Println("task hashes are identical between Rust and Go!")
 		}
 	}
 

cli/internal/run/run.go

@@ -164,6 +164,7 @@ func (r *run) run(ctx gocontext.Context, targets []string, executionState *turbo
 	} else {
 		pkgDepGraph, err = context.BuildPackageGraph(r.base.RepoRoot, rootPackageJSON, executionState.PackageManager)
 	}
+
 	if err != nil {
 		var warnings *context.Warnings
 		if errors.As(err, &warnings) {

crates/turborepo-env/src/lib.rs

@@ -14,6 +14,7 @@ use thiserror::Error;
 const DEFAULT_ENV_VARS: [&str; 1] = ["VERCEL_ANALYTICS_ID"];
 
 /// Environment mode after we've resolved the `Infer` variant
+#[derive(Debug)]
 pub enum ResolvedEnvMode {
     Loose,
     Strict,

crates/turborepo-lib/src/hash/mod.rs

@@ -42,6 +42,7 @@ mod proto_capnp {
     }
 }
 
+#[derive(Debug)]
 pub struct TaskHashable<'a> {
     // hashes
     pub(crate) global_hash: &'a str,

crates/turborepo-lib/src/hash/proto.capnp

@@ -22,8 +22,9 @@ struct TaskHashable {
     dotEnv @12 :List(Text);
 
     enum EnvMode {
-      loose @0;
-      strict @1;
+      infer @0;
+      loose @1;
+      strict @2;
     }
 }
 

crates/turborepo-lib/src/run/mod.rs

@@ -354,7 +354,6 @@ impl Run {
         );
 
         visitor.visit(engine.clone()).await?;
-
         let task_hash_tracker = visitor.into_task_hash_tracker();
 
         Ok((global_hash, task_hash_tracker))

crates/turborepo-lib/src/task_hash.rs

@@ -304,6 +304,9 @@ impl<'a> TaskHasher<'a> {
             env_mode: task_env_mode,
             dot_env: &task_definition.dot_env,
         };
+
+        println!("task hashable: {:#?}", task_hashable);
+
         let task_hash = task_hashable.hash();
 
         let mut task_hash_tracker = self.task_hash_tracker.lock().await;