This repository has been archived by the owner on Jan 21, 2023. It is now read-only.
Make it super fast #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. |
styfle
commented
Jan 28, 2019
|
@styfle Hey! Thanks! |
|
Hi Marvin, Take a look at line 3 to see the global variable. Think of it like a local cache, it’s not guaranteed to be populated because the function might scale up and create a new instance or it might scale down to 0 when there is no traffic. |
noahflk
pushed a commit
to noahflk/og-image
that referenced
this pull request
Apr 15, 2021
Make it super fast
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34
Keep a browser around in global scope