Skip to content

Upgrade the version of glob #389

Open
@ematipico

Description

The current version of glob uses an outdated - very outdated - version of minimatch. That version of micromatch is CommonJS only and it breaks production code when deployed to serverless function.

For more reading: withastro/astro#9935

Activity

JasonTame

JasonTame commented on Feb 2, 2024

@JasonTame

Minor correction - it's minimatch that is outdated with the current version of glob, not micromatch

linked a pull request that will close this issue on Feb 2, 2024
styfle

styfle commented on Feb 2, 2024

@styfle
Member

I started a PR here but looks like Windows is failing since glob has changed from backslash to forward slash

If someone who has windows wants to fix it, feel free.

added
dependenciesPull requests that update a dependency file
on Feb 2, 2024
anviksuteiriy

anviksuteiriy commented on Sep 11, 2024

@anviksuteiriy

Hey, any update on this since there is a warning of memory leak reported for this version glob --> inflight ?

Screenshot from 2024-09-11 12-17-34

benmccann

benmccann commented on Dec 9, 2024

@benmccann
Contributor

It might be a good opportunity to switch glob libraries

https://npmgraph.js.org/?q=glob - 26 dependencies
https://npmgraph.js.org/?q=tinyglobby - 2 dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    dependenciesPull requests that update a dependency filehelp wantedExtra attention is needed

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Upgrade the version of `glob` · Issue #389 · vercel/nft