Repository navigation
[ci] Improve change detection logic in run-for-change script - #85619
Merged
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
unstubbable
force-pushed
the
hl/extract-change-detection-logic
branch
from
October 31, 2025 12:32
801c516 to
95469b2
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
unstubbable
force-pushed
the
hl/extract-change-detection-logic
branch
from
October 31, 2025 12:44
95469b2 to
165ce02
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
unstubbable
force-pushed
the
hl/extract-change-detection-logic
branch
from
October 31, 2025 12:51
165ce02 to
63da77e
Compare
This PR extracts the existing git change detection logic from the `get-changed-tests` script into a separate module. This allows reusing the same logic in the `run-for-change` script, ensuring consistent behavior across the two scripts to determine changed files. Specifically, this ensures that in stacked PRs, the docs-only change detection (and the test-only change detection in the upstack PR) works correctly by diffing against the appropriate base branch.
unstubbable
force-pushed
the
hl/extract-change-detection-logic
branch
from
October 31, 2025 12:54
63da77e to
eaca0c2
Compare
Member
Tests Passed |
unstubbable
marked this pull request as ready for review
October 31, 2025 13:36
ijjk
approved these changes
Oct 31, 2025
huozhi
pushed a commit
that referenced
this pull request
Nov 12, 2025
This PR extracts the existing git change detection logic from the `get-changed-tests` script into a separate module. This allows reusing the same logic in the `run-for-change` script, ensuring consistent behavior across the two scripts to determine changed files. Specifically, this ensures that in stacked PRs, the docs-only change detection (and the test-only change detection in the upstack PR) works correctly by diffing against the appropriate base branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extracts the existing git change detection logic from the
get-changed-testsscript into a separate module. This allows reusing the same logic in therun-for-changescript, ensuring consistent behavior across the two scripts to determine changed files. Specifically, this ensures that in stacked PRs, the docs-only change detection (and the test-only change detection in the upstack PR) works correctly by diffing against the appropriate base branch.