refactor(cargo): Clean up cargo build configs

[bgw]

Try to improve consistency, de-duplicate options, and remove some config for unsupported targets.

[bgw]

• perf(turbopack/swc): Add icf to builds, reducing binary size #75497
• refactor(cargo): Clean up cargo build configs #75498 👈 (View in Graphite)
• canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

[bgw]

Apparently I added this line when I enabled lld and I'm not sure why. Doesn't seem to be useful?

[bgw]

We dropped support for 32-bit Windows a few months back because nobody is using it.

[bgw]

Similar to 32-bit Windows, I don't think anyone should be using this. Turbopack's only going to be useful on tiny projects if limited to 2 GB of RAM, plus arm is a niche platform to begin with. It doesn't look like we had CI for this anyways.

[bgw]

This is already the default? Probably just not cleaned up from prior changes.

[ijjk]

Failing test suites

Commit: d6a29f4

pnpm test-start-turbo test/e2e/app-dir/dynamic-io/dynamic-io.routes.test.ts (turbopack)

• dynamic-io > should not prerender GET route handlers that use dynamic APIs
• dynamic-io > should prerender GET route handlers that have entirely cached io (fetches)
• dynamic-io > should not prerender GET route handlers that have some uncached io (fetches)
• dynamic-io > should prerender GET route handlers that have entirely cached io (unstable_cache)
• dynamic-io > should prerender GET route handlers that have entirely cached io ("use cache")
• dynamic-io > should not prerender GET route handlers that have some uncached io (unstable_cache)
• dynamic-io > should prerender GET route handlers that complete synchronously or in a microtask
• dynamic-io > should not prerender GET route handlers that complete in a new Task
• dynamic-io > should prerender GET route handlers when accessing awaited params
• dynamic-io > should prerender GET route handlers when accessing params without awaiting first

Expand output

● dynamic-io › should not prerender GET route handlers that use dynamic APIs

next build failed with code/signal 1

   98 |           if (code || signal)
   99 |             reject(
> 100 |               new Error(`next build failed with code/signal ${code || signal}`)
      |               ^
  101 |             )
  102 |           else resolve()
  103 |         })

  at ChildProcess.<anonymous> (lib/next-modes/next-start.ts:100:15)

● dynamic-io › should prerender GET route handlers that have entirely cached io (fetches)

next build failed with code/signal 1

   98 |           if (code || signal)
   99 |             reject(
> 100 |               new Error(`next build failed with code/signal ${code || signal}`)
      |               ^
  101 |             )
  102 |           else resolve()
  103 |         })

  at ChildProcess.<anonymous> (lib/next-modes/next-start.ts:100:15)

● dynamic-io › should not prerender GET route handlers that have some uncached io (fetches)

next build failed with code/signal 1

   98 |           if (code || signal)
   99 |             reject(
> 100 |               new Error(`next build failed with code/signal ${code || signal}`)
      |               ^
  101 |             )
  102 |           else resolve()
  103 |         })

  at ChildProcess.<anonymous> (lib/next-modes/next-start.ts:100:15)

● dynamic-io › should prerender GET route handlers that have entirely cached io (unstable_cache)

next build failed with code/signal 1

   98 |           if (code || signal)
   99 |             reject(
> 100 |               new Error(`next build failed with code/signal ${code || signal}`)
      |               ^
  101 |             )
  102 |           else resolve()
  103 |         })

  at ChildProcess.<anonymous> (lib/next-modes/next-start.ts:100:15)

● dynamic-io › should prerender GET route handlers that have entirely cached io ("use cache")

next build failed with code/signal 1

   98 |           if (code || signal)
   99 |             reject(
> 100 |               new Error(`next build failed with code/signal ${code || signal}`)
      |               ^
  101 |             )
  102 |           else resolve()
  103 |         })

  at ChildProcess.<anonymous> (lib/next-modes/next-start.ts:100:15)

● dynamic-io › should not prerender GET route handlers that have some uncached io (unstable_cache)

next build failed with code/signal 1

   98 |           if (code || signal)
   99 |             reject(
> 100 |               new Error(`next build failed with code/signal ${code || signal}`)
      |               ^
  101 |             )
  102 |           else resolve()
  103 |         })

  at ChildProcess.<anonymous> (lib/next-modes/next-start.ts:100:15)

● dynamic-io › should prerender GET route handlers that complete synchronously or in a microtask

next build failed with code/signal 1

   98 |           if (code || signal)
   99 |             reject(
> 100 |               new Error(`next build failed with code/signal ${code || signal}`)
      |               ^
  101 |             )
  102 |           else resolve()
  103 |         })

  at ChildProcess.<anonymous> (lib/next-modes/next-start.ts:100:15)

● dynamic-io › should not prerender GET route handlers that complete in a new Task

next build failed with code/signal 1

   98 |           if (code || signal)
   99 |             reject(
> 100 |               new Error(`next build failed with code/signal ${code || signal}`)
      |               ^
  101 |             )
  102 |           else resolve()
  103 |         })

  at ChildProcess.<anonymous> (lib/next-modes/next-start.ts:100:15)

● dynamic-io › should prerender GET route handlers when accessing awaited params

next build failed with code/signal 1

   98 |           if (code || signal)
   99 |             reject(
> 100 |               new Error(`next build failed with code/signal ${code || signal}`)
      |               ^
  101 |             )
  102 |           else resolve()
  103 |         })

  at ChildProcess.<anonymous> (lib/next-modes/next-start.ts:100:15)

● dynamic-io › should prerender GET route handlers when accessing params without awaiting first

next build failed with code/signal 1

   98 |           if (code || signal)
   99 |             reject(
> 100 |               new Error(`next build failed with code/signal ${code || signal}`)
      |               ^
  101 |             )
  102 |           else resolve()
  103 |         })

  at ChildProcess.<anonymous> (lib/next-modes/next-start.ts:100:15)

Read more about building and testing Next.js in contributing.md.

pnpm test-dev-turbo test/development/acceptance/error-recovery.test.ts (turbopack)

• ReactRefreshLogBox turbo > syntax > runtime error

Expand output

● ReactRefreshLogBox turbo › syntax > runtime error

Application is in inconsistent state: timeout.

  93 |             }
  94 |             if (status !== 'pending') {
> 95 |               throw new Error(
     |                     ^
  96 |                 `Application is in inconsistent state: ${status}.`
  97 |               )
  98 |             }

  at Object.patch (lib/development-sandbox.ts:95:21)
  at Object.<anonymous> (development/acceptance/error-recovery.test.ts:416:5)

Read more about building and testing Next.js in contributing.md.

[ijjk]

Stats from current PR

Default Build (Increase detected ⚠️)

General

	vercel/next.js canary	vercel/next.js bgw/build-config-cleanup	Change
buildDuration	20.3s	18.7s	N/A
buildDurationCached	17.8s	15.1s	N/A
nodeModulesSize	391 MB	391 MB	✓
nextStartRea..uration (ms)	480ms	480ms	✓

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js bgw/build-config-cleanup	Change
5306-HASH.js gzip	54 kB	54 kB	N/A
8276.HASH.js gzip	169 B	168 B	N/A
8377-HASH.js gzip	5.46 kB	5.46 kB	N/A
bccd1874-HASH.js gzip	52.9 kB	52.9 kB	N/A
framework-HASH.js gzip	57.5 kB	57.5 kB	N/A
main-app-HASH.js gzip	241 B	242 B	N/A
main-HASH.js gzip	34.5 kB	34.4 kB	N/A
webpack-HASH.js gzip	1.71 kB	1.71 kB	N/A
Overall change	0 B	0 B	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js bgw/build-config-cleanup	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Overall change	39.4 kB	39.4 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js bgw/build-config-cleanup	Change
_app-HASH.js gzip	193 B	193 B	✓
_error-HASH.js gzip	193 B	193 B	✓
amp-HASH.js gzip	512 B	510 B	N/A
css-HASH.js gzip	343 B	342 B	N/A
dynamic-HASH.js gzip	1.84 kB	1.84 kB	✓
edge-ssr-HASH.js gzip	265 B	265 B	✓
head-HASH.js gzip	363 B	362 B	N/A
hooks-HASH.js gzip	393 B	392 B	N/A
image-HASH.js gzip	4.59 kB	4.58 kB	N/A
index-HASH.js gzip	268 B	268 B	✓
link-HASH.js gzip	2.35 kB	2.35 kB	N/A
routerDirect..HASH.js gzip	328 B	328 B	✓
script-HASH.js gzip	397 B	397 B	✓
withRouter-HASH.js gzip	323 B	326 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.59 kB	3.59 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js bgw/build-config-cleanup	Change
_buildManifest.js gzip	748 B	747 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js bgw/build-config-cleanup	Change
index.html gzip	524 B	522 B	N/A
link.html gzip	539 B	538 B	N/A
withRouter.html gzip	520 B	520 B	✓
Overall change	520 B	520 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js bgw/build-config-cleanup	Change
edge-ssr.js gzip	129 kB	129 kB	N/A
page.js gzip	210 kB	210 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js bgw/build-config-cleanup	Change
middleware-b..fest.js gzip	670 B	665 B	N/A
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	31.3 kB	31.3 kB	N/A
edge-runtime..pack.js gzip	844 B	844 B	✓
Overall change	844 B	844 B	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js bgw/build-config-cleanup	Change
app-page-exp...dev.js gzip	385 kB	385 kB	✓
app-page-exp..prod.js gzip	132 kB	132 kB	✓
app-page-tur..prod.js gzip	145 kB	145 kB	✓
app-page-tur..prod.js gzip	141 kB	141 kB	✓
app-page.run...dev.js gzip	372 kB	372 kB	✓
app-page.run..prod.js gzip	128 kB	128 kB	✓
app-route-ex...dev.js gzip	39.3 kB	39.3 kB	✓
app-route-ex..prod.js gzip	25.6 kB	25.6 kB	✓
app-route-tu..prod.js gzip	25.6 kB	25.6 kB	✓
app-route-tu..prod.js gzip	25.4 kB	25.4 kB	✓
app-route.ru...dev.js gzip	40.8 kB	40.8 kB	✓
app-route.ru..prod.js gzip	25.4 kB	25.4 kB	✓
dist_client_...dev.js gzip	356 B	356 B	✓
dist_client_...dev.js gzip	349 B	349 B	✓
pages-api-tu..prod.js gzip	9.69 kB	9.69 kB	✓
pages-api.ru...dev.js gzip	11.8 kB	11.8 kB	✓
pages-api.ru..prod.js gzip	9.68 kB	9.68 kB	✓
pages-turbo...prod.js gzip	21.9 kB	21.9 kB	✓
pages.runtim...dev.js gzip	31.5 kB	31.5 kB	✓
pages.runtim..prod.js gzip	21.9 kB	21.9 kB	✓
server.runti..prod.js gzip	60.2 kB	60.2 kB	✓
Overall change	1.65 MB	1.65 MB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js bgw/build-config-cleanup	Change
0.pack gzip	2.1 MB	2.1 MB	⚠️ +683 B
index.pack gzip	76.1 kB	75.2 kB	N/A
Overall change	2.1 MB	2.1 MB	⚠️ +683 B

Diff details

Diff for main-HASH.js

Diff too large to display

Commit: d6a29f4